Recover corrupted volume cache #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upted Signed-off-by: Natalie Arellano <narellano@vmware.com>
…e corrupted Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
restore-checks-sha
branch
2 times, most recently
from
3cf82c4
to
d0ccbee
Compare
natalieparellano
force-pushed
the
restore-checks-sha
branch
from
aef2a33
to
fa0b6ce
Compare
joeybrown-sf
approved these changes
Oct 23, 2024
jabrown85
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This builds upon the work of @joeybrown-sf in #1381 / buildpacks/lifecycle-private#16 by skipping restore & cache re-use for layers whose contents do not match their declared sha.
Release notes
The lifecycle skips restore & cache re-use for (cache volume) layers whose contents do not match their declared sha
Related
Resolves #1407
Context
Make sure to hide whitespace when viewing the diff, because I cleaned up some test nesting