Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-merge release branches into main #429

Open
yaelharel opened this issue Oct 6, 2020 · 7 comments
Open

Auto-merge release branches into main #429

yaelharel opened this issue Oct 6, 2020 · 7 comments
Labels
help wanted Need some extra hands to the this done. status/ready type/chore

Comments

@yaelharel
Copy link
Contributor

yaelharel commented Oct 6, 2020

Now, after we moved the release process to Github Actions (see #415), we would like to add a Github Actions workflow for auto-merging release branches into main after the releases are published on every commit to the release branch.

@yaelharel
Copy link
Contributor Author

@natalieparellano
Copy link
Member

Do we want to do this when the release is published or on new pushes to the release branch?

@yaelharel
Copy link
Contributor Author

@natalieparellano, it is an interesting question!
I thought about doing it once the release is published since, at that point, we'll be sure that everything works as expected, but there are also advantages of doing so on every commit to the release branch.
Maybe the answer relates to a different question - when are we planning to create the release branch.
If we plan to do so at the beginning of the development for this release, then it might take time to publish it and then it's probably better to run the merge on every commit so main will be up to date.
But if we plan to create the release branch close to cutting the release, then I think it's better to auto merge only after publishing the release from the reason I wrote above and because the branch won't exist for a long time.
What do you think?

@dfreilich
Copy link
Member

Pack does this whenever there is a new push to the release branch. It helps make sure that the two branches (main and release) don't end up out of sync, so it doesn't hold off on development that isn't making it into this release.

@yaelharel
Copy link
Contributor Author

@dfreilich, thanks for your input!
Can you please share when do we create a release branch for pack, and for how long does it usually exist?

@dfreilich
Copy link
Member

dfreilich commented Oct 13, 2020

Typically a release branch exists for 5 business days. The process is detailed here. Ideally releases should only happen every 6 weeks, with our cadence, but with hotfixes (etc), they tend to happen a bit more frequently... 😅

@yaelharel
Copy link
Contributor Author

@dfreilich, thanks again!
So @natalieparellano, back to your question - assuming that we'll work similar to pack, and assuming that there won't be too many commits to the release branch, I guess we can run the auto-merge on every commit.
I'll change the description of this issue.
Thanks!

@natalieparellano natalieparellano added this to the lifecycle-0.13.0 milestone Sep 22, 2021
@natalieparellano natalieparellano removed this from the lifecycle-0.13.0 milestone Feb 25, 2022
@natalieparellano natalieparellano added the help wanted Need some extra hands to the this done. label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need some extra hands to the this done. status/ready type/chore
Projects
None yet
Development

No branches or pull requests

4 participants