Move release automation to Github actions #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaelharel
force-pushed
the
fix/389-github-actions-release
branch
from
054ee00 to
0dc4ca0
Compare
yaelharel
commented
Sep 24, 2020
yaelharel
commented
Sep 24, 2020
yaelharel
commented
Sep 24, 2020
yaelharel
commented
Sep 24, 2020
yaelharel
commented
Sep 24, 2020
.github/workflows/draft-release.yml
Outdated
| }) | ||
| .then(workflow_runs_result => { | ||
| let workflow_runs = workflow_runs_result.data.workflow_runs | ||
| .filter(run => run.conclusion === "success"); |
There was a problem hiding this comment.
We plan to additionally add a check that the SHA is correct.
ekcasey
reviewed
Sep 30, 2020
natalieparellano
force-pushed
the
fix/389-github-actions-release
branch
from
aef5782 to
55ec216
Compare
|
@ekcasey we think this should be good to go - but we'd like to run the acceptance on our fork one more time (likely on Monday). |
added 3 commits
October 2, 2020 16:33
For local development and commits to main, we derive the lifecycle version from `git describe --tags`. For new commits to release branches, we derive the lifecycle version from the branch name. New commits to main and release branches will trigger a new lifecycle image. After publishing new releases, the lifecycle image will be re-tagged. PRs to any branch won't trigger a new lifecycle image. Signed-off-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Yael Harel <yharel@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
- update github-script to the latest version v3.0.0 - refactor packager - publish the linux and windows lifecycle images after all tests passed (on ubuntu) - determine download urls for linux and windows in one step - check that the head sha of the last successful workflow is the last sha Signed-off-by: Yael Harel <yharel@vmware.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
fix/389-github-actions-release
branch
from
55ec216 to
eb5db1a
Compare
Without clean, the artifact will be what was built from the acceptance tests (with a test version) since the source code didn't change between builds. Signed-off-by: Natalie Arellano <narellano@vmware.com>
ekcasey
approved these changes
Oct 5, 2020
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For local development and commits to main, we derive the lifecycle version from
git describe --tags.For new commits to release branches, we derive the lifecycle version from the branch name.
New commits to main and release branches will trigger a new lifecycle image.
After publishing new releases, the lifecycle image will be re-tagged.
PRs to any branch won't trigger a new lifecycle image.
Signed-off-by: Natalie Arellano narellano@vmware.com
This PR should fix issue #389