Validate the cache image and previous image in the analyze phase

[matthewrobertson]

Updates the analyzer to only reuse layers from the previous app image or cache image if they are not corrupt. This uses the new imgutil::Valid() that was added in buildpacks/imgutil#190

Fixes #1044

[matthewrobertson]

I actually tested this end to end by creating a custom builder with my updated lifecycle and it seems like this is not sufficient to solve the issue. I can see the corrupt image is ignored during analysis but I am now getting a new error while exporting:

ERROR: failed to export: previous image did not have layer with diff id "sha256:7dd44d3eb001c70a8cfc002f048f29a3ee3ba335356f1b4d2f7cf8d0cc29173a"
ERROR: failed to build: executing lifecycle: failed with status code: 62

[matthewrobertson]

OK figured it out, all is well. I got confused by some nested conditionals... I have now tested end to end and confirmed that this is working properly and it handles previous app images and cache images with missing layers.

@natalieparellano @jabrown85 this is ready for review now.

[matthewrobertson]

windows failures are fixed by this PR in imgutil: buildpacks/imgutil#196

[jabrown85]

@matthewrobertson looks like we still have failures in windows about corrupt images. https://github.com/buildpacks/lifecycle/actions/runs/4758563102/jobs/8456787984?pr=1060#step:6:6897

If you don't have any ideas maybe we can get someone with a windows rig to help take a look

[matthewrobertson]

I still see logs like "Ignoring cache image "xxx" because it was corrupt" in test output. I will poke around to see if I can figure out why they are failing the validation.

[matthewrobertson]

@jabrown85 looks like the code was doing what it was supposed to do 😄 Windows base image layers weren't being pushed to the registry because of this: https://docs.docker.com/engine/reference/commandline/dockerd/#allow-push-of-nondistributable-artifacts

Should be fixed now 🤞

[jabrown85]

Nice work! I'll let @natalieparellano weigh in as well before merge but it looks great to me and all the tests are now passing 😄