Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize all tar file timestamps to Jan 01 1980 +1 second #108

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

djoyahoy
Copy link
Member

@djoyahoy djoyahoy commented Apr 1, 2019

  • This prevents an issue where certain versions of the jdk
    cannot parse jar file creation times

[buildpacks/pack#130]

Signed-off-by: Danny Joyce djoyce@pivotal.io
Signed-off-by: Andrew Meyer ameyer@pivotal.io

* This prevents an issue where certain versions of the jdk
  cannot parse jar file creation times

[buildpacks/pack#130]

Signed-off-by: Danny Joyce <djoyce@pivotal.io>
Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
Copy link
Member

@sclevine sclevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as-is, but you might consider pulling the time out into a constant.

@djoyahoy djoyahoy merged commit dc96f50 into master Apr 1, 2019
@djoyahoy djoyahoy deleted the tar-timestamps branch April 1, 2019 19:04
joeybrown added a commit to joeybrown/dotknet that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants