Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for run image extension #1134

Merged
merged 10 commits into from
Jul 5, 2023
Merged

Fixes for run image extension #1134

merged 10 commits into from
Jul 5, 2023

Commits on Jun 30, 2023

  1. When pulling remote image data, fail if the remote image is not found 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    b698140 View commit details
    Browse the repository at this point in the history

  2. When validating dockerfiles, set extend to true if there are any inst… 

    …ructions (vs more than one instruction)

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    13f323f View commit details
    Browse the repository at this point in the history

  3. Update matching logic when considering if two image names are equival… 

    …ent to ignore the digest portion of the reference if present (for the purpose of selecting data from run.toml to add to the lifecycle metadata label i.e., “run image for rebase”)

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    bedfb81 View commit details
    Browse the repository at this point in the history

  4. Comments and cleanup 

    Don't print `%!s(<nil>)` if nil is provided to the "parse maybe" function

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    2afaa5a View commit details
    Browse the repository at this point in the history

  5. When exporting, continue to use run image identifier (which could be … 

    …a digest reference or daemon image ID)

instead of falling back to image name when exporting to a daemon.

Previously, the digest reference was incorrect which caused the daemon not to find the image.
But when provided a correct digest reference the daemon can still find it.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    a5a1425 View commit details
    Browse the repository at this point in the history

  6. Add Contains method to structs that hold run image information for ex… 

    …port

When determining if a provided reference is found in existing metadata, remove its digest -
except when setting the new run image "image" in analyzed.toml,
because we should always respect what the extension author wrote.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    47480dd View commit details
    Browse the repository at this point in the history

  7. When finding the run image info for export, use the run image "image"… 

    … (name)

in analyzed.toml as the search key, because the run image "reference" could be a daemon image ID
or include the digest, which isn't helpful when retrieving image names that are supposed to float.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    07a7676 View commit details
    Browse the repository at this point in the history

  8. Fix detector acceptance and add more logging 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    debf8de View commit details
    Browse the repository at this point in the history

  9. Fix: use "image" instead of "reference" and also guard against image … 

    …not found

when we are only updating the reference and target data in analyzed.toml

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    eb08a3c View commit details
    Browse the repository at this point in the history

  10. Add comment 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    ff750f3 View commit details
    Browse the repository at this point in the history