-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix restorer target update #1159
Fix restorer target update #1159
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
…te run image Signed-off-by: Natalie Arellano <narellano@vmware.com>
TDD notes... Failing test (prior to code changes): https://github.com/buildpacks/lifecycle/actions/runs/5660989254/job/15337920259#step:5:10277 Note that
prints Oddly, I couldn't get this to fail locally. Locally, the run image reference returned is something like I'm assuming this has something to do with oddities around the test registry, but I'm not sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in the sense that unit tests don't lie, but it's a little mysterious.
There was something wrong with my local setup, I can see the failing tests now. All good! |
When we instantiate the remote image for the purpose of checking target data, we should provide "from base image" so that we don't end up returning data for an empty image