Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing flags for OCI Layout to restorer #1195

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented Sep 4, 2023

Summary

This PR adds the layout and layout-dir flags to the restorer phase when the PLATFORM_API version is equal or greater than 0.12.

It also fixes an issue when the run-image is read from the analyzed.toml file we will get something like:

{
"Reference":"",
  "Image":"/layout-repo/index.docker.io/cnbs/sample-stack-run/jammy",
   "Extend":false,
   "target":{
     "os":"linux",
    "arch":"amd64"
 }
}

We were trying to parse the Reference.Image into a path, but it is already a path, so we don't need to do anything in that case.

Release notes

When using platform API 0.12 or greater, The layout flags layout and layout-dir were exposed in the restorer binary


Related

Resolves #1194


Context

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante marked this pull request as ready for review September 5, 2023 16:51
@jjbustamante jjbustamante requested a review from a team as a code owner September 5, 2023 16:51
@natalieparellano natalieparellano added this to the lifecycle 0.17.1 milestone Sep 7, 2023
@natalieparellano natalieparellano merged commit aeb177c into main Sep 7, 2023
7 checks passed
@natalieparellano natalieparellano deleted the bugfix/jjbustamante/issue-1194 branch September 7, 2023 16:37
natalieparellano pushed a commit that referenced this pull request Sep 12, 2023
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running the restorer configured with OCI Layout flags throws an error
2 participants