refactor phase/generator_test.go
#1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil9909
force-pushed
the
refactor-generator-test
branch
from
4c0e800
to
8e2edd2
Compare
Signed-off-by: Philipp Stehle <philipp.stehle@sap.com> Signed-off-by: Johannes Dillmann <j.dillmann@sap.com> Co-authored-by: Philipp Stehle <philipp.stehle@sap.com>
phil9909
force-pushed
the
refactor-generator-test
branch
from
8e2edd2
to
550574e
Compare
natalieparellano
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
@phil9909 thank you for this! This should make the tests a lot easier to maintain going forward :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
phase/generator_test.goas suggested in #1276 (comment).Related PR #1297
Context
In #1276 we duplicated some of the test code in
phase/generator_test.go, basically doing the same tests twice, once for Platform API0.12and once for0.13. The API versions expect a different folder layout, which requires changes to the test setup and assertions. The reduce the size ofphase/generator_test.go, we:platformAPI.AtLeast("0.13")switches where file paths are differentNow we have every tests only once in code, while still being executed twice (even the ones that we previously only had for platform API 0.12).
CC @natalieparellano