When copying extended run image layers, use the original layer count #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yers in addition to the original top layer digest to determine what is an extension layer and what is an original layer. Relying on the original top layer digest (only) introduced errors if the original run image had a duplicated top layer. Fixes #1300 Signed-off-by: Natalie Arellano <narellano@vmware.com>
jabrown85
approved these changes
Mar 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
- Coverage 64.62% 64.59% -0.02%
==========================================
Files 101 101
Lines 6994 6997 +3
==========================================
Hits 4519 4519
- Misses 2064 2067 +3
Partials 411 411
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(in addition to the original top layer digest) to determine what is an extension layer and what is an original layer.
Relying on the original top layer digest (only) introduced errors if the original run image had a duplicated top layer.
Fixes #1300
Summary
Uses the original layer count (in addition to the original top layer digest) to determine what is an extension layer and what is an original layer.
Release notes
Fixes issue where the
extenderfails to copy extension layers when the original run image has a duplicated top layerRelated
Resolves #1300
Context
I looked into unit testing this, but decided it wasn't worth it