Show group detection conditions first #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when outputting from group detection, the name of the buildpack is displayed ahead of the condition. For example: Buildpack-1: pass Buildpack-with-longer-name: pass BP-short: fail As the example shows, conditions are not vertically aligned. This makes it harder to visually scan for 'pass', 'fail' etc. It also makes it harder to write scripts that automatically parse lifecycle output. This commit puts the conditions ahead of the buildpack name: pass: Buildpack-1 pass: Buildpack-with-longer-name fail: BP-short Signed-off-by: Jacques Chester <jchester@pivotal.io>
sclevine
approved these changes
May 14, 2019
|
Are we awaiting a second approval? |
jkutner
approved these changes
May 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when outputting from group detection, the name of the buildpack is displayed ahead of the condition. For example:
As the example shows, conditions are not vertically aligned. This makes it harder to visually scan for 'pass', 'fail' etc. It also makes it harder to write scripts that automatically parse lifecycle output.
This commit puts the conditions ahead of the buildpack name:
(This PR replaces the pig's breakfast that I and git-duet created in #133)