-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove separate packages for platform interface implementation #771
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Also makes the code slightly more efficient by having the |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #771 +/- ##
==========================================
+ Coverage 62.32% 65.49% +3.17%
==========================================
Files 59 55 -4
Lines 4100 4059 -41
==========================================
+ Hits 2555 2658 +103
+ Misses 1283 1121 -162
- Partials 262 280 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
7ff19b9
to
9d710f4
Compare
Despite having advocated the current approach, I now regret it. Having to duplicate the entire previous platform when a new version is supported is not optimal. E.g. for platform 0.8, the only difference from 0.7 is that standardized sBOM is now supported, but we had to copy the entire directory and essentially do a find and replace to get everything to compile.
It would be awesome if we could still move logic into the
platform
package (e.g. here, this could be aSupportsSBOM
field or method onPlatform
). But the proposed organization would allow us to do this at our own pace, and reduce a fair amount of duplication.