Allow storing multiple commands instead of a single string #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow storing multiple commands instead of a single string This is a first step to implementing #322. This PR is updating our internal structs to allow for a slice of commands while keeping the external API and behavior the same. A future PR will implement handling multiple commands depending on the API version and changing the behavior of the launcher and metadat file output changes. Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Comment on usage of cmp.Option Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Add comment on Matches interface usage for testing Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Added test for launch.toml decoding branching logic Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Apply suggestions from code review Signed-off-by: Jesse Brown <jabrown85@gmail.com> Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com> * fixup! Apply suggestions from code review * fixup! Apply suggestions from code review * Fix editing daemon settings Signed-off-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com> Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com>
natalieparellano
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
I think we need to satisfy the linter but otherwise this looks good to me. Thanks for slogging through this thorny issue @jabrown85 :)
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introducing 5fa84a4 with fixes to the panic that resulted in the revert.
This is a first step to implementing #322. This PR is updating our internal structs to allow for a slice of commands while keeping the external API and behavior the same. A future PR will implement handling multiple commands depending on the API version and changing the behavior of the launcher and metadat file output changes.
I did also run the
packacceptance tests pointing at the linux lifecycle and it was 👍#900