renames CNB_ANALYZE_SKIP_LAYERS to CNB_SKIP_LAYERS #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you need to fix DCO (See failed GitHub check) |
to match spec and resolve FIXME Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
joe-kimmel-vmw
force-pushed
the
fix-one-fixme
branch
from
a79a38c to
b0e9037
Compare
|
Related Slack conversation: https://cloud-native.slack.com/archives/C033DV9EBDF/p1668721420968799 Though there's low probability anyone is using this (or else we would have heard about it by now) it may be safer to guard this on a platform API version bump. I put this on the agenda for tomorrow's WG (1/5/23) to discuss. |
|
Per 1/5/23 we decided that just renaming the variable is fine as the current usage isn't documented anywhere. |
natalieparellano
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so name matches spec and resolves FIXME