Merge pull request #1744 from joe-kimmel-vmw/jkutner/dep-updates

inspect image: add one unit test
buildpacks · May 5, 2023 · dee7a7e · dee7a7e
2 parents 8e03c74 + 0ca7318
commit dee7a7e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/pkg/client/inspect_image.go b/pkg/client/inspect_image.go
@@ -177,7 +177,7 @@ func (c *Client) InspectImage(name string, daemon bool) (*ImageInfo, error) {
 	}
 
 	var stackCompat platform.StackMetadata
-	if layersMd.RunImage.Image != "" { // TODO: add unit
+	if layersMd.RunImage.Image != "" {
 		stackCompat = layersMd.RunImage.ToStackMetadata()
 	} else {
 		stackCompat = layersMd.Stack

diff --git a/pkg/client/inspect_image_test.go b/pkg/client/inspect_image_test.go
@@ -214,6 +214,23 @@ func testInspectImage(t *testing.T, when spec.G, it spec.S) {
 					h.AssertEq(t, infoWithExtension.StackID, "test.stack.id")
 				})
 
+				it("returns the stack from runImage.Image if set", func() {
+					h.AssertNil(t, mockImage.SetLabel(
+						"io.buildpacks.lifecycle.metadata",
+						`{
+  "runImage": {
+    "topLayer": "some-top-layer",
+    "reference": "some-run-image-reference",
+    "image":  "is everything"
+  }
+}`,
+					))
+					info, err := subject.InspectImage("some/image", useDaemon)
+					h.AssertNil(t, err)
+					h.AssertEq(t, info.Stack,
+						platform.StackMetadata{RunImage: platform.RunImageForExport{Image: "is everything"}})
+				})
+
 				it("returns the stack", func() {
 					info, err := subject.InspectImage("some/image", useDaemon)
 					h.AssertNil(t, err)