Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when no extensions are available pack builder inspect should show extensions none #1613

Closed
jjbustamante opened this issue Jan 30, 2023 · 2 comments · Fixed by #1710
Closed
Assignees
Labels
status/triage Issue or PR that requires contributor attention. type/bug Issue that reports an unexpected behaviour.

Comments

@jjbustamante
Copy link
Member

jjbustamante commented Jan 30, 2023

Summary

During the developing of the issue #1486 we agreed on now showing anything related to extensions when the are not present. We don't want to affect the user experience, it could be somebody out there that is parsing the output of the inspect command.


Reproduction

Steps
  1. Make sure you have access to a builder without extensions.
  2. Run the command pack builder inspect <builder-image>
  3. The output result will contain all the expected information but it will also include a section like:
Extensions:
  (none)
Current behavior

Based on this PR the output template was modified to include:

Extensions:
  (none)

When no extensions are found

Expected behavior

When there are no extensions, we don't want to show anything related to extensions in the output


Environment

pack info

This feature hasn't released yet, it is shown if the latest version of the main branch is built.

docker info

NA

@jjbustamante jjbustamante added status/triage Issue or PR that requires contributor attention. type/bug Issue that reports an unexpected behaviour. labels Jan 30, 2023
@itsdarshankumar
Copy link
Contributor

pls assign @jjbustamante

@itsdarshankumar
Copy link
Contributor

Mistakenly unassigned @natalieparellano from notification, apologies, pls reassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/triage Issue or PR that requires contributor attention. type/bug Issue that reports an unexpected behaviour.
Projects
None yet
2 participants