Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show extensions only if they are present for all output format in inspect builder #1710

Merged
merged 6 commits into from
Apr 11, 2023

Conversation

itsdarshankumar
Copy link
Contributor

@itsdarshankumar itsdarshankumar commented Apr 6, 2023

Summary

When there are no extensions, we don't want to show anything related to extensions in the output

Output

With Extensions:
image

Without Extensions:
image

Before

image

After

image

Related

Resolves #1613

Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
@itsdarshankumar itsdarshankumar requested review from a team as code owners April 6, 2023 20:10
@itsdarshankumar itsdarshankumar marked this pull request as draft April 6, 2023 20:10
@github-actions github-actions bot added this to the 0.30.0 milestone Apr 6, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Apr 6, 2023
Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
@itsdarshankumar itsdarshankumar marked this pull request as ready for review April 10, 2023 21:21
@itsdarshankumar itsdarshankumar changed the title show extensions only if they are present for humanreadable format show extensions only if they are present for all output format in inspect builder Apr 10, 2023
Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Apr 10, 2023
Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
@jkutner jkutner merged commit 18dcd82 into buildpacks:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when no extensions are available pack builder inspect should show extensions none
2 participants