Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pack buildpack downloader should support extension packages #1684

Closed
natalieparellano opened this issue Mar 24, 2023 · 2 comments · Fixed by #1757
Closed

pack buildpack downloader should support extension packages #1684

natalieparellano opened this issue Mar 24, 2023 · 2 comments · Fixed by #1757
Assignees
@itsdarshankumar
Labels
good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.

Comments

@natalieparellano
Copy link
Member

Summary

Once #1661 is merged the buildpack downloader should handle extension packages instead of returning nil here.

We should probably add an acceptance test that uses extension packages in a builder to ensure that things are working end-to-end.
@natalieparellano natalieparellano added type/bug Issue that reports an unexpected behaviour. good first issue A good first issue to get started with. status/ready Issue ready to be worked on. labels Mar 24, 2023
@natalieparellano natalieparellano mentioned this issue Mar 24, 2023
Merged
@itsdarshankumar
Copy link
Contributor

would like to continue this @natalieparellano once my PR is merged

@natalieparellano
Copy link
Member Author

Thank you @itsdarshankumar! I'll assign you the issue

@itsdarshankumar itsdarshankumar mentioned this issue May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsdarshankumar itsdarshankumar

Labels
good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for extensions in pack Buildpack downloader itsdarshankumar/pack
2 participants
@natalieparellano @itsdarshankumar