-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for extensions in pack Buildpack downloader #1757
Add support for extensions in pack Buildpack downloader #1757
Conversation
Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
84142bf
to
a31c35b
Compare
Thank you @itsdarshankumar - this looks great! Would it be possible to add a test case to pkg/buildpack/downloader_test.go? Something along the lines of:
The other tests in this context (for buildpacks) would probably be redundant for extensions. |
sure, I'll add the test cases |
Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
… tar in test Signed-off-by: Darshan Kumar <itsdarshankumar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @itsdarshankumar! IMO Codecov is being too picky... this will really smooth out the experience of using extensions for end users!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @itsdarshankumar !!!
Summary
Adds feature to add packaged extensions while creating a builder
Output
Before
Used to throw SIGSEV
Related
Resolves #1684