Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when volume mounting into /workspace #2237

Closed
dmikusa opened this issue Jul 25, 2024 · 3 comments · Fixed by #2238
Closed

Warn when volume mounting into /workspace #2237

dmikusa opened this issue Jul 25, 2024 · 3 comments · Fixed by #2238
Labels
good first issue A good first issue to get started with. help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Milestone
0.36.0

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Jul 25, 2024

Description

This isn’t a super common problem, but we do occasionally see people mount into workspace.

a.) It doesn’t make a ton of sense. /workspace is your app files, so if you want it there, just include it with your app files.
b.) Buildpacks can delete files in /workspace. For example, if you do a source build it’s common to delete all the source code so it’s not in the production image. Well, if you volume map into /workspace, your mapped files might get deleted too.

Proposed solution

Warn so users know it's not a good idea
@dmikusa dmikusa added status/triage Issue or PR that requires contributor attention. type/enhancement Issue that requests a new feature or improvement. labels Jul 25, 2024
@natalieparellano natalieparellano added status/ready Issue ready to be worked on. help wanted Need some extra hands to get this done. good first issue A good first issue to get started with. and removed status/triage Issue or PR that requires contributor attention. labels Jul 25, 2024
@natalieparellano natalieparellano added this to the 0.36.0 milestone Jul 25, 2024
anthonydahanne added a commit to anthonydahanne/pack that referenced this issue Jul 29, 2024
@anthonydahanne
Fix buildpacks#2237: consider /workspace as a sensitive dir
b60eae8
This was referenced Jul 29, 2024
Merged
Closed
@CodeWreckPro
Copy link

Is anyone currently contributing to this issue?, I would like to pick up the issue.

@dmikusa
Copy link
Contributor Author

dmikusa commented Jul 29, 2024

Looks like maybe @anthonydahanne is working on it?

@anthonydahanne
Copy link
Contributor

yes, already submitted a PR #2238

natalieparellano added a commit that referenced this issue Jul 29, 2024
@natalieparellano
Merge pull request #2238 from anthonydahanne/2237-workspace-sensitive
c253591 
Fix #2237: consider /workspace as a sensitive dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good first issue to get started with. help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.36.0
Development

Successfully merging a pull request may close this issue.

Fix #2237: consider /workspace as a sensitive dir anthonydahanne/pack
4 participants
@anthonydahanne @dmikusa @natalieparellano @CodeWreckPro