Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack update-stack allows a user update an existing stack #36

Closed
ssisil opened this issue Oct 1, 2018 · 3 comments
Closed

pack update-stack allows a user update an existing stack #36

ssisil opened this issue Oct 1, 2018 · 3 comments
Assignees

Comments

@ssisil
Copy link

ssisil commented Oct 1, 2018

WHEN I run pack update-stack my.custom.stack.id --run-image my-org/run --build-image my-org/build
THEN the stack with the ID my.custom.stack.id will update the existing images for the stack in the config.toml with the ones specified
AND the user will see the following message "<stack id> successfully updated."

Notes

  • Multiple run and build images can be provided
  • If stack id does not exist - return the following message "<stack id> does not exist. Please run pack update-stack with an existing stack ID."
@dgodd dgodd self-assigned this Oct 4, 2018
@dgodd
Copy link
Contributor

dgodd commented Oct 4, 2018

I have assumed that if either run-image or build-image is not specified then that entry is unchanged. This means it is NOT possible for a user to set the array for either to empty; this seems reasonable to me (why would you want to do that after all?)

@ssisil
Copy link
Author

ssisil commented Oct 4, 2018

@dgodd - Agreed- seems like a weird edge case to support

dgodd added a commit that referenced this issue Oct 4, 2018
WHEN I run pack update-stack my.custom.stack.id --run-image my-org/run --build-image my-org/build
THEN the stack with the ID my.custom.stack.id will update the existing images for the stack in the config.toml with the ones specified
AND the user will see the following message "<stack id> successfully updated."

[#36]
@ssisil
Copy link
Author

ssisil commented Oct 5, 2018

@dgodd

Seeing this error message -

ssisil:bin ssisil$ pack update-stack io.buildpacks.stacks.scott-xenial --build-image ssisil/build:xenial-2 --run-image ssisil/run:xenial-2
Error: Missing stack: stack with id "io.buildpacks.stacks.scott-xenial" not found in pack config.toml

Should be this

"io.buildpacks.stacks.scott-xenial" does not exist. Please run pack update-stack with an existing stack ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants