Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to standard library when validating zip file #1238

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

aemengo
Copy link
Contributor

@aemengo aemengo commented Jul 22, 2021

Summary

Go stdlib zip format validation looks non-trivial. Might be worth delegating..

Output

Before

$ pack build sample-app --path target/sample-0.0.1-SNAPSHOT.jar --builder cnbs/sample-builder:bionic
ERROR: failed to build: invalid app path 'target/sample-0.0.1-SNAPSHOT.jar': app path must be a directory or zip

After

$ pack build sample-app --path target/sample-0.0.1-SNAPSHOT.jar --builder cnbs/sample-builder:bionic
...

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1236

Signed-off-by: Anthony Emengo <aemengo@vmware.com>
@github-actions github-actions bot added this to the 0.20.0 milestone Jul 22, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jul 22, 2021
@aemengo aemengo marked this pull request as ready for review July 22, 2021 20:49
@aemengo aemengo requested a review from a team as a code owner July 22, 2021 20:49
@jromero jromero modified the milestones: 0.20.0, 0.21.0 Aug 9, 2021
@jromero jromero merged commit d9624aa into buildpacks:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zip files with preamble text are not recognized by pack build
2 participants