Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds deprecation warnings to pack stack comands #1706

Merged
merged 5 commits into from
Apr 13, 2023

Conversation

joe-kimmel-vmw
Copy link
Contributor

Summary

adds deprecation warnings.

Output

Before

After

➜  pack git:(stackrecommenddepwarning) ✗ ./out/pack stack                                            
(Deprecated)
Stacks will continue to be supported through at least 2024 but are deprecated in favor of using BuildImages and RunImages directly. Please see our docs for more details- https://buildpacks.io/docs/concepts/components/stack

Usage:
  pack stack [command]

Available Commands:
  suggest     (deprecated) List the recommended stacks

Flags:
  -h, --help   help for stack

Global Flags:
      --no-color     Disable color output
  -q, --quiet        Show less output
      --timestamps   Enable timestamps in output
  -v, --verbose      Show more output

Use "pack stack [command] --help" for more information about a command.

and

➜  pack git:(stackrecommenddepwarning) ✗ ./out/pack stack suggest                                     
Stacks maintained by the community:

    Stack ID: Deprecation Notice
    Description: Stacks will continue to be supported through at least 2024 but are deprecated in favor of using BuildImages and RunImages directly. Please see our docs for more details- https://buildpacks.io/docs/concepts/components/stack
    Maintainer: CNB
    Build Image:
    Run Image:

    Stack ID: heroku-20
    Description: The official Heroku stack based on Ubuntu 20.04
    Maintainer: Heroku
    Build Image: heroku/heroku:20-cnb-build
    Run Image: heroku/heroku:20-cnb

    Stack ID: io.buildpacks.stacks.bionic
    Description: A minimal Paketo stack based on Ubuntu 18.04
    Maintainer: Paketo Project
    Build Image: paketobuildpacks/build:base-cnb
    Run Image: paketobuildpacks/run:base-cnb

    Stack ID: io.buildpacks.stacks.bionic
    Description: A large Paketo stack based on Ubuntu 18.04
    Maintainer: Paketo Project
    Build Image: paketobuildpacks/build:full-cnb
    Run Image: paketobuildpacks/run:full-cnb

    Stack ID: io.paketo.stacks.tiny
    Description: A tiny Paketo stack based on Ubuntu 18.04, similar to distroless
    Maintainer: Paketo Project
    Build Image: paketobuildpacks/build:tiny-cnb
    Run Image: paketobuildpacks/run:tiny-cnb

Documentation

this change is documentation

Related

Resolves #___

@github-actions github-actions bot added this to the 0.30.0 milestone Apr 5, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Apr 5, 2023
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
@joe-kimmel-vmw joe-kimmel-vmw marked this pull request as ready for review April 11, 2023 00:28
@joe-kimmel-vmw joe-kimmel-vmw requested review from a team as code owners April 11, 2023 00:28
@jkutner jkutner enabled auto-merge April 11, 2023 14:45
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
auto-merge was automatically disabled April 13, 2023 00:28

Head branch was pushed to by a user without write access

@jkutner jkutner enabled auto-merge April 13, 2023 12:51
@jkutner jkutner merged commit 28d211d into buildpacks:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants