-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade default lifecycle to 0.17.0-pre.2 #1730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
github-actions
bot
added
the
type/enhancement
Issue that requests a new feature or improvement.
label
Apr 18, 2023
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
github-actions
bot
added
the
type/chore
Issue that requests non-user facing changes.
label
Apr 18, 2023
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
This will fail in CI until there is a lifecycle-0.17.0-pre.2 Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
add one Rebase unit test and fix nil handling
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
inspect image: add one unit test
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Just to provide a brief update here, the plan of action seems to be:
|
It is nested under `[run]` so `run-image` is redundant Signed-off-by: Natalie Arellano <narellano@vmware.com>
Skip stack validation when not supported Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
…-pre2 upgrades to the latest lifecycle pre-release
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
changed the title
Upgrade default lifecycle to 0.17.0-pre.1
Upgrade default lifecycle to 0.17.0-pre.2
May 18, 2023
jjbustamante
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job!!! LGTM
hone
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type/chore
Issue that requests non-user facing changes.
type/enhancement
Issue that requests a new feature or improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set default lifecycle to
0.17.0-pre.2
Documentation
Related
Resolves #___