Create benchmark.yml and add end-to-end benchmark #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/chore
benchmarks/build_test.go
Outdated
| trustedImg = baseImg + "-trusted-" | ||
| builder = "cnbs/sample-builder:bionic" | ||
| mockAppPath = filepath.Join("..", "acceptance", "testdata", "mock_app") | ||
| paketoBuilder = "paketobuildpacks/builder:base" |
There was a problem hiding this comment.
Could we make this configurable with an env var or something? It would be nice to make it easy for contributors to test this out with builders that they care about.
There was a problem hiding this comment.
Sure, I have created setEnv() to set these values. If value is not set in the environment, default values will be assigned. setEnv() will be invoked at first of BenchmarkBuild(). Does this treatment make sense?
| alert-threshold: '200%' | ||
| comment-on-alert: true | ||
| fail-on-alert: true | ||
| alert-comment-cc-users: '@edithwuly' |
There was a problem hiding this comment.
Eventually we'll probably want this to be '@buildpacks/platform-maintainers' but this will be helpful to reduce noise while we're iterating on the benchmark suite
There was a problem hiding this comment.
Ok, so I just leave @edithwuly here temporarily.
Signed-off-by: edithwuly <edithwuly@163.com>
Signed-off-by: edithwuly <edithwuly@163.com>
Signed-off-by: edithwuly <edithwuly@163.com>
Signed-off-by: edithwuly <edithwuly@163.com>
edithwuly
force-pushed
the
main
branch
2 times, most recently
from
c740838
to
1fb39b1
Compare
Signed-off-by: edithwuly <edithwuly@163.com>
jkutner
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create git action to keep runing benchmarks and graphing the results each time push on main branch. Benchmark for
pack build --buildpackis added as well.Output
The graphs for benchmark results will be shown in https://buildpack.github.io/pack/dev/bench/.
Before
Brank branch
gh-pagesis required for saving benchmark result data. index.html and data.js will be created automatically.alert-thresholdandalert-comment-cc-usersfield should be decided.After
Documentation
Related
Resolves #___