change additional buildpack to java #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: edithwuly <edithwuly@163.com>
github-actions
bot
added
type/chore
natalieparellano
added a commit
that referenced
this pull request
May 23, 2023
The previous benchmarks used a buildpack that was small in size, hence any performance improvements would be hard to spot. #1773 will switch the buildpack to a large buildpack, thus making the benchmark more useful. Signed-off-by: Natalie Arellano <narellano@vmware.com>
2 tasks
|
@buildpacks/platform-maintainers could you please merge this PR first: #1777 |
2 tasks
jkutner
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change additional buildpack for benchmark to java.
Output
The time spent on adding additional buildpack for
pack buildwill be more apparent.Before
Old additional buildpack is too small to show the difference after some optimizations are made.
After
Java buildpack is much bigger. Hopefully, we can see obvious drop in benchmark graphs.
Documentation
Related
Resolves #___