Flatten buildpack package is move to be experimental #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll need how it affects the distribution spec Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
github-actions
bot
added
the
type/enhancement
natalieparellano
approved these changes
May 26, 2023
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
|
@dfreilich , @hone , @jkutner Can I have some eyes or this PR merge? |
jjbustamante
force-pushed
the
enhancement/flatten-buildpackage-experimental
branch
from
ad71c5c
to
f5e7be2
Compare
github-actions
bot
added
type/chore
jjbustamante
force-pushed
the
enhancement/flatten-buildpackage-experimental
branch
from
253b060
to
d2be746
Compare
Adding test case for warning message Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
jjbustamante
force-pushed
the
enhancement/flatten-buildpackage-experimental
branch
from
d2be746
to
37747ef
Compare
github-actions
bot
removed
the
type/chore
5 tasks
dfreilich
requested changes
Jun 15, 2023
@dfreilich thanks for your feedback. We already have a TIP message to guide users, it is shown like this:
|
jkutner
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After our working group meeting today (05/25/2023) some concerns were raised with breaking the distribution spec flattening a buildpack package. This pull request is wrapping the functionality to be under the experimetal mode, it means, users will need to enable the experimental mode in order to see the new flags. Also, a warning message is display to end users. The idea is to do not block the feature for being released but still have the open conversation with the community in how the spec is being broke.
Output
Before
--flatten,--depthandflatten-excludeflags were added to be available with thepack buildpack packagecommand.After
The flags were hidden if experimental mode is not enabled
They will be only available when experimental mode is enabled
Documentation
Related
Resolves #1595