Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: deriving stack.toml from the new run image information #1788

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Fix: deriving stack.toml from the new run image information #1788

merged 2 commits into from
Jun 20, 2023

Conversation

natalieparellano
Copy link
Member

...we should write the file with the correct schema

Fixes bug identified during Working Group demo

@natalieparellano
When deriving stack.toml from the new run image information
2e1b3a5 
  2 we should write the file with the correct schema

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested review from a team as code owners May 30, 2023 21:10
@github-actions github-actions bot added this to the 0.30.0 milestone May 30, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label May 30, 2023
@natalieparellano natalieparellano changed the title When deriving stack.toml from the new run image information Fix: deriving stack.toml from the new run image information May 30, 2023
@natalieparellano natalieparellano mentioned this pull request May 30, 2023
Closed
5 tasks
@jjbustamante jjbustamante added type/bug Issue that reports an unexpected behaviour. stack removal and removed type/enhancement Issue that requests a new feature or improvement. labels Jun 7, 2023
jjbustamante
jjbustamante approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

dfreilich
dfreilich approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@jkutner jkutner enabled auto-merge June 20, 2023 15:54
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jun 20, 2023
@jkutner jkutner merged commit 1f35e85 into main Jun 20, 2023
@jkutner jkutner deleted the fix/stack-toml-from-run-table branch June 20, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreilich dfreilich dfreilich approved these changes

@jjbustamante jjbustamante jjbustamante approved these changes

@jkutner jkutner jkutner approved these changes

Assignees
No one assigned
Labels
stack removal type/bug Issue that reports an unexpected behaviour. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.
4 participants
@natalieparellano @jkutner @jjbustamante @dfreilich