Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups from PR review #1813

Merged
merged 7 commits into from
Jun 28, 2023
Merged

Cleanups from PR review #1813

merged 7 commits into from
Jun 28, 2023
+139 −147

Commits on Jun 27, 2023

  1. Cleanups from PR review 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    6f50a75 View commit details
    Browse the repository at this point in the history

  2. Fix more stuff 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e7c0a12 View commit details
    Browse the repository at this point in the history

  3. Update comment 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    cead534 View commit details
    Browse the repository at this point in the history

  4. Variable rename and pend tests to see if acceptance is passing 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e14d0d9 View commit details
    Browse the repository at this point in the history

  5. Fix units by not writing parent headers twice 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    03116fe View commit details
    Browse the repository at this point in the history

  6. Try to fix Windows 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    84ee822 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Other small cleanups 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    d5cc7d9 View commit details
    Browse the repository at this point in the history