Warn if project.toml contains keys not supported by schema #2042

colincasey · 2024-01-30T16:00:58Z

Summary

As detailed in #1922, a common source of confusion with project.toml is failing to declare the schema-version. The schema-version then silently defaults to 0.1 which can lead to confusing and hard to debug errors when the user is using keys from the 0.2 schema.

This PR adds messaging to the build output notifying the user if:

the schema version defaults to 0.1
the project descriptor contains unsupported keys for the target schema version and these keys will be ignored

Output

Before

Using project descriptor located at '/var/folders/r4/xq3q_hjj2v1ghqlnr1k1zrdw0000gp/T/unsupported-schema-keys-app2010798657/project.toml'
Builder 'localhost:55020/test/builder-meaprzkkef' is trusted
Warning: Ignoring the provided lifecycle image as the builder is trusted, running the creator in a single container using the provided builder
Pulling image 'localhost:55020/test/builder-meaprzkkef:latest'
latest: Pulling from test/builder-meaprzkkef
Digest: sha256:b23b53c8d15aefb31136b9c2cda830a62a801bfb3fad413c3496a775c3ca9bc1
Status: Image is up to date for localhost:55020/test/builder-meaprzkkef:latest
CheckReadAccess failed for the run image pack-test/run, error: HEAD https://index.docker.io/v2/pack-test/run/manifests/latest: unexpected status code 401 Unauthorized (HEAD responses have no body, use GET for details)
CheckReadAccess succeeded for the run image localhost:55020/pack-test/run
Selected run image mirror 'localhost:55020/pack-test/run'
Pulling image 'localhost:55020/pack-test/run'
latest: Pulling from pack-test/run
Digest: sha256:39b229916f00ebfd4e824e7d55f55d31679ab856f0ce6590ab156c85088f09f8
Status: Image is up to date for localhost:55020/pack-test/run:latest
Creating builder with the following buildpacks:
-> 'read/env@read-env-version'
-> 'noop.buildpack@noop.buildpack.version'
-> 'noop.buildpack@noop.buildpack.later-version'
-> 'simple/layers@simple-layers-version'
Using build cache volume 'pack-cache-some-org_yrjscyouuj_latest-82c320b56cc2.build'
Running the 'creator' on OS 'linux' from image 'pack.local/builder/616d78677a73746b7975:latest' with:
Container Settings:
  Args: '/cnb/lifecycle/creator -daemon -launch-cache /launch-cache -log-level debug -app /workspace -cache-dir /cache -run-image localhost:55020/pack-test/run localhost:55020/some-org/yrjscyouuj'
  System Envs: 'CNB_PLATFORM_API=0.12'
  Image: 'pack.local/builder/616d78677a73746b7975:latest'
  User: 'root'
  Labels: 'map[author:pack]'
Host Settings:
  Binds: 'pack-cache-some-org_yrjscyouuj_latest-82c320b56cc2.build:/cache /var/run/docker.sock:/var/run/docker.sock pack-cache-some-org_yrjscyouuj_latest-82c320b56cc2.launch:/launch-cache pack-layers-gpqabucfga:/layers pack-app-zzbdnhrczc:/workspace'
  Network Mode: ''
Starting creator...
Parsing inputs...
Ensuring privileges...
Executing command...
===> ANALYZING
Timer: Analyzer started at 2024-01-30T15:57:26Z
Image with name "localhost:55020/some-org/yrjscyouuj" not found
Found image with identifier "0fd546a7ba0d7372c867c5e481935bf45fab514ed73ed65574c23010b4014b3a"
Timer: Analyzer ran for 89.712µs and ended at 2024-01-30T15:57:26Z
Run image info in analyzed metadata is: 
{"Reference":"0fd546a7ba0d7372c867c5e481935bf45fab514ed73ed65574c23010b4014b3a","Image":"localhost:55020/pack-test/run","Extend":false,"target":{"os":"linux","arch":"amd64"}}
===> DETECTING
Timer: Detector started at 2024-01-30T15:57:26Z
Checking for match against descriptor: {windows   []}
Checking for match against descriptor: {linux   []}
Checking for match against descriptor: {windows   []}
Checking for match against descriptor: {linux   []}
======== Output: read/env@read-env-version ========
---> DETECT: Printenv buildpack
======== Results ========
pass: simple/layers@simple-layers-version
err:  read/env@read-env-version (1)
Resolving plan... (try #1)
1 of 2 buildpacks participating
simple/layers simple-layers-version
Timer: Detector ran for 3.066373ms and ended at 2024-01-30T15:57:26Z
===> RESTORING
Timer: Restorer started at 2024-01-30T15:57:26Z
Restoring Layer Metadata
Reading buildpack directory: /layers/simple_layers
Reading Buildpack Layers directory /layers
Reading buildpack directory: /layers/simple_layers
Timer: Restorer ran for 216.031µs and ended at 2024-01-30T15:57:26Z
===> BUILDING
Timer: Builder started at 2024-01-30T15:57:26Z
Running build for buildpack simple/layers@simple-layers-version
Looking up buildpack
Finding plan
Creating plan directory
Preparing paths
Running build command
---> Build: Simple Layers Buildpack
making launch layer
Color: Styled
making cached launch layer
---> Done
Processing layers
Updating environment
Reading output files
Updating buildpack processes
Updating process list
Finished running build for buildpack simple/layers@simple-layers-version
Copying SBOM files
Creating SBOM files for legacy BOM
Listing processes
Timer: Builder ran for 7.72566ms and ended at 2024-01-30T15:57:26Z
===> EXPORTING
Timer: Exporter started at 2024-01-30T15:57:26Z
Copying SBOM lifecycle.sbom.cdx.json to /layers/sbom/build/buildpacksio_lifecycle/sbom.cdx.json
Copying SBOM lifecycle.sbom.spdx.json to /layers/sbom/build/buildpacksio_lifecycle/sbom.spdx.json
Copying SBOM lifecycle.sbom.syft.json to /layers/sbom/build/buildpacksio_lifecycle/sbom.syft.json
Copying SBOM launcher.sbom.cdx.json to /layers/sbom/launch/buildpacksio_lifecycle/launcher/sbom.cdx.json
Copying SBOM launcher.sbom.spdx.json to /layers/sbom/launch/buildpacksio_lifecycle/launcher/sbom.spdx.json
Copying SBOM launcher.sbom.syft.json to /layers/sbom/launch/buildpacksio_lifecycle/launcher/sbom.syft.json
Reading buildpack directory: /layers/simple_layers
Reading buildpack directory item: cached-launch-layer
Reading buildpack directory item: cached-launch-layer.toml
Reading buildpack directory item: launch-layer
Reading buildpack directory item: launch-layer.toml
Reading buildpack directory item: launch.toml
Processing buildpack directory: /layers/simple_layers
Processing launch layer: /layers/simple_layers/cached-launch-layer
Reusing tarball for layer "simple/layers:cached-launch-layer" with SHA: sha256:86da3c03587957e4e7571259d7cefb913e991ddb19164862f40159362b78f3a0
Adding layer 'simple/layers:cached-launch-layer'
Layer 'simple/layers:cached-launch-layer' SHA: sha256:86da3c03587957e4e7571259d7cefb913e991ddb19164862f40159362b78f3a0
Processing launch layer: /layers/simple_layers/launch-layer
Reusing tarball for layer "simple/layers:launch-layer" with SHA: sha256:c7c0f2d747d3a9c4908676a95162751870928838385c678252d009c0e9dcbf8d
Adding layer 'simple/layers:launch-layer'
Layer 'simple/layers:launch-layer' SHA: sha256:c7c0f2d747d3a9c4908676a95162751870928838385c678252d009c0e9dcbf8d
Found SBOM of type launch for at /layers/sbom/launch
Reusing tarball for layer "buildpacksio/lifecycle:launch.sbom" with SHA: sha256:f04b500e5e9718eb5f2e88a2f45b379c54582cceb4d45fd646ae4fd667544833
Adding layer 'buildpacksio/lifecycle:launch.sbom'
Layer 'buildpacksio/lifecycle:launch.sbom' SHA: sha256:f04b500e5e9718eb5f2e88a2f45b379c54582cceb4d45fd646ae4fd667544833
Layer 'slice-1' SHA: sha256:56485c63acd23a4bb4c2126a7ccd5f7a64eb4294363d37b2c38a3d440a91877f
Adding 1/1 app layer(s)
Reusing tarball for layer "buildpacksio/lifecycle:launcher" with SHA: sha256:99546a12b358b8416518f8f76b3ef3b6488dea026b1d6e7528e0c81a140e364c
Adding layer 'buildpacksio/lifecycle:launcher'
Layer 'buildpacksio/lifecycle:launcher' SHA: sha256:99546a12b358b8416518f8f76b3ef3b6488dea026b1d6e7528e0c81a140e364c
Reusing tarball for layer "buildpacksio/lifecycle:config" with SHA: sha256:500dce5089145ac4c359c37c209e91d0a54b20db0f6196b78c0b366bbd529af2
Adding layer 'buildpacksio/lifecycle:config'
Layer 'buildpacksio/lifecycle:config' SHA: sha256:500dce5089145ac4c359c37c209e91d0a54b20db0f6196b78c0b366bbd529af2
Reusing tarball for layer "buildpacksio/lifecycle:process-types" with SHA: sha256:af8140367e05484cbc8b071fa4405dc0f2c8d72047eeef495d1c73794a31aaa8
Adding layer 'buildpacksio/lifecycle:process-types'
Layer 'buildpacksio/lifecycle:process-types' SHA: sha256:af8140367e05484cbc8b071fa4405dc0f2c8d72047eeef495d1c73794a31aaa8
Adding label 'io.buildpacks.lifecycle.metadata'
Adding label 'io.buildpacks.build.metadata'
Adding label 'io.buildpacks.project.metadata'
Setting CNB_LAYERS_DIR=/layers
Setting CNB_APP_DIR=/workspace
Setting CNB_PLATFORM_API=0.12
Setting CNB_DEPRECATION_MODE=quiet
Prepending /cnb/process and /cnb/lifecycle to PATH
Setting WORKDIR: '/workspace'
Setting default process type 'web'
Setting ENTRYPOINT: '/cnb/process/web'
Timer: Saving localhost:55020/some-org/yrjscyouuj... started at 2024-01-30T15:57:26Z
Saving localhost:55020/some-org/yrjscyouuj...
*** Images (c410a9758de7):
      localhost:55020/some-org/yrjscyouuj

*** Image ID: c410a9758de7b42452be22acc8885f09c0a4ac7ee8b50a9c254b784422d0e96a
Timer: Saving localhost:55020/some-org/yrjscyouuj... ran for 98.867761ms and ended at 2024-01-30T15:57:26Z
Timer: Exporter ran for 114.362919ms and ended at 2024-01-30T15:57:26Z
Timer: Cache started at 2024-01-30T15:57:26Z
Reading buildpack directory: /layers/simple_layers
Reading buildpack directory item: cached-launch-layer
Reading buildpack directory item: cached-launch-layer.toml
Reading buildpack directory item: launch-layer
Reading buildpack directory item: launch-layer.toml
Reading buildpack directory item: launch.toml
Reusing tarball for layer "simple/layers:cached-launch-layer" with SHA: sha256:86da3c03587957e4e7571259d7cefb913e991ddb19164862f40159362b78f3a0
Adding cache layer 'simple/layers:cached-launch-layer'
Layer 'simple/layers:cached-launch-layer' SHA: sha256:86da3c03587957e4e7571259d7cefb913e991ddb19164862f40159362b78f3a0
Timer: Cache ran for 415.234µs and ended at 2024-01-30T15:57:26Z
Successfully built image 'localhost:55020/some-org/yrjscyouuj'

After

Warning: No schema version declared in project.toml, defaulting to schema version 0.1
Warning: The following keys declared in project.toml are not supported in schema version 0.1:
Warning: - unsupported-table
Warning: - unsupported-table.unsupported-key
Warning: The above keys will be ignored. If this is not intentional, maybe try updating your schema version.
Using project descriptor located at '/var/folders/r4/xq3q_hjj2v1ghqlnr1k1zrdw0000gp/T/unsupported-schema-keys-app3484545732/project.toml'
Builder 'localhost:55019/test/builder-jsxduvkchu' is trusted
Warning: Ignoring the provided lifecycle image as the builder is trusted, running the creator in a single container using the provided builder
Pulling image 'localhost:55019/test/builder-jsxduvkchu:latest'
latest: Pulling from test/builder-jsxduvkchu
Digest: sha256:7cbf27f1aab214ce606fdfc0e2b2893556a87d236f28b4031ec0be4887077fc4
Status: Image is up to date for localhost:55019/test/builder-jsxduvkchu:latest
CheckReadAccess failed for the run image pack-test/run, error: HEAD https://index.docker.io/v2/pack-test/run/manifests/latest: unexpected status code 401 Unauthorized (HEAD responses have no body, use GET for details)
CheckReadAccess succeeded for the run image localhost:55019/pack-test/run
Selected run image mirror 'localhost:55019/pack-test/run'
Pulling image 'localhost:55019/pack-test/run'
latest: Pulling from pack-test/run
Digest: sha256:b50b903bd1bc071b62c51245fc3370b5395ee491a243d187957328ef09fe7dd7
Status: Image is up to date for localhost:55019/pack-test/run:latest
Creating builder with the following buildpacks:
-> 'read/env@read-env-version'
-> 'noop.buildpack@noop.buildpack.version'
-> 'noop.buildpack@noop.buildpack.later-version'
-> 'simple/layers@simple-layers-version'
Using build cache volume 'pack-cache-some-org_kfwylzvwwb_latest-cfa683507d8c.build'
Running the 'creator' on OS 'linux' from image 'pack.local/builder/72616369697a6c666d70:latest' with:
Container Settings:
  Args: '/cnb/lifecycle/creator -daemon -launch-cache /launch-cache -log-level debug -app /workspace -cache-dir /cache -run-image localhost:55019/pack-test/run localhost:55019/some-org/kfwylzvwwb'
  System Envs: 'CNB_PLATFORM_API=0.12'
  Image: 'pack.local/builder/72616369697a6c666d70:latest'
  User: 'root'
  Labels: 'map[author:pack]'
Host Settings:
  Binds: 'pack-cache-some-org_kfwylzvwwb_latest-cfa683507d8c.build:/cache /var/run/docker.sock:/var/run/docker.sock pack-cache-some-org_kfwylzvwwb_latest-cfa683507d8c.launch:/launch-cache pack-layers-ozsnlglowg:/layers pack-app-oimwptfqrk:/workspace'
  Network Mode: ''
Starting creator...
Parsing inputs...
Ensuring privileges...
Executing command...
===> ANALYZING
Timer: Analyzer started at 2024-01-30T15:51:05Z
Image with name "localhost:55019/some-org/kfwylzvwwb" not found
Found image with identifier "26aa2577d4ca6bc9484aabea2f11aa98f77af7ca62ef7641e706650d8b7fd85f"
Timer: Analyzer ran for 40.04µs and ended at 2024-01-30T15:51:05Z
Run image info in analyzed metadata is: 
{"Reference":"26aa2577d4ca6bc9484aabea2f11aa98f77af7ca62ef7641e706650d8b7fd85f","Image":"localhost:55019/pack-test/run","Extend":false,"target":{"os":"linux","arch":"amd64"}}
===> DETECTING
Timer: Detector started at 2024-01-30T15:51:05Z
Checking for match against descriptor: {windows   []}
Checking for match against descriptor: {linux   []}
Checking for match against descriptor: {windows   []}
Checking for match against descriptor: {linux   []}
======== Output: read/env@read-env-version ========
---> DETECT: Printenv buildpack
======== Results ========
pass: simple/layers@simple-layers-version
err:  read/env@read-env-version (1)
Resolving plan... (try #1)
1 of 2 buildpacks participating
simple/layers simple-layers-version
Timer: Detector ran for 3.30326ms and ended at 2024-01-30T15:51:05Z
===> RESTORING
Timer: Restorer started at 2024-01-30T15:51:05Z
Restoring Layer Metadata
Reading buildpack directory: /layers/simple_layers
Reading Buildpack Layers directory /layers
Reading buildpack directory: /layers/simple_layers
Timer: Restorer ran for 148.084µs and ended at 2024-01-30T15:51:05Z
===> BUILDING
Timer: Builder started at 2024-01-30T15:51:05Z
Running build for buildpack simple/layers@simple-layers-version
Looking up buildpack
Finding plan
Creating plan directory
Preparing paths
Running build command
---> Build: Simple Layers Buildpack
making launch layer
Color: Styled
making cached launch layer
---> Done
Processing layers
Updating environment
Reading output files
Updating buildpack processes
Updating process list
Finished running build for buildpack simple/layers@simple-layers-version
Copying SBOM files
Creating SBOM files for legacy BOM
Listing processes
Timer: Builder ran for 8.209206ms and ended at 2024-01-30T15:51:05Z
===> EXPORTING
Timer: Exporter started at 2024-01-30T15:51:05Z
Copying SBOM lifecycle.sbom.cdx.json to /layers/sbom/build/buildpacksio_lifecycle/sbom.cdx.json
Copying SBOM lifecycle.sbom.spdx.json to /layers/sbom/build/buildpacksio_lifecycle/sbom.spdx.json
Copying SBOM lifecycle.sbom.syft.json to /layers/sbom/build/buildpacksio_lifecycle/sbom.syft.json
Copying SBOM launcher.sbom.cdx.json to /layers/sbom/launch/buildpacksio_lifecycle/launcher/sbom.cdx.json
Copying SBOM launcher.sbom.spdx.json to /layers/sbom/launch/buildpacksio_lifecycle/launcher/sbom.spdx.json
Copying SBOM launcher.sbom.syft.json to /layers/sbom/launch/buildpacksio_lifecycle/launcher/sbom.syft.json
Reading buildpack directory: /layers/simple_layers
Reading buildpack directory item: cached-launch-layer
Reading buildpack directory item: cached-launch-layer.toml
Reading buildpack directory item: launch-layer
Reading buildpack directory item: launch-layer.toml
Reading buildpack directory item: launch.toml
Processing buildpack directory: /layers/simple_layers
Processing launch layer: /layers/simple_layers/cached-launch-layer
Reusing tarball for layer "simple/layers:cached-launch-layer" with SHA: sha256:86da3c03587957e4e7571259d7cefb913e991ddb19164862f40159362b78f3a0
Adding layer 'simple/layers:cached-launch-layer'
Layer 'simple/layers:cached-launch-layer' SHA: sha256:86da3c03587957e4e7571259d7cefb913e991ddb19164862f40159362b78f3a0
Processing launch layer: /layers/simple_layers/launch-layer
Reusing tarball for layer "simple/layers:launch-layer" with SHA: sha256:c7c0f2d747d3a9c4908676a95162751870928838385c678252d009c0e9dcbf8d
Adding layer 'simple/layers:launch-layer'
Layer 'simple/layers:launch-layer' SHA: sha256:c7c0f2d747d3a9c4908676a95162751870928838385c678252d009c0e9dcbf8d
Found SBOM of type launch for at /layers/sbom/launch
Reusing tarball for layer "buildpacksio/lifecycle:launch.sbom" with SHA: sha256:f04b500e5e9718eb5f2e88a2f45b379c54582cceb4d45fd646ae4fd667544833
Adding layer 'buildpacksio/lifecycle:launch.sbom'
Layer 'buildpacksio/lifecycle:launch.sbom' SHA: sha256:f04b500e5e9718eb5f2e88a2f45b379c54582cceb4d45fd646ae4fd667544833
Layer 'slice-1' SHA: sha256:11463a1d7b4e218b8bb1ecdbb12f5db3bdfc59fd7c4110222d3279aedb2d2590
Adding 1/1 app layer(s)
Reusing tarball for layer "buildpacksio/lifecycle:launcher" with SHA: sha256:99546a12b358b8416518f8f76b3ef3b6488dea026b1d6e7528e0c81a140e364c
Adding layer 'buildpacksio/lifecycle:launcher'
Layer 'buildpacksio/lifecycle:launcher' SHA: sha256:99546a12b358b8416518f8f76b3ef3b6488dea026b1d6e7528e0c81a140e364c
Reusing tarball for layer "buildpacksio/lifecycle:config" with SHA: sha256:500dce5089145ac4c359c37c209e91d0a54b20db0f6196b78c0b366bbd529af2
Adding layer 'buildpacksio/lifecycle:config'
Layer 'buildpacksio/lifecycle:config' SHA: sha256:500dce5089145ac4c359c37c209e91d0a54b20db0f6196b78c0b366bbd529af2
Reusing tarball for layer "buildpacksio/lifecycle:process-types" with SHA: sha256:af8140367e05484cbc8b071fa4405dc0f2c8d72047eeef495d1c73794a31aaa8
Adding layer 'buildpacksio/lifecycle:process-types'
Layer 'buildpacksio/lifecycle:process-types' SHA: sha256:af8140367e05484cbc8b071fa4405dc0f2c8d72047eeef495d1c73794a31aaa8
Adding label 'io.buildpacks.lifecycle.metadata'
Adding label 'io.buildpacks.build.metadata'
Adding label 'io.buildpacks.project.metadata'
Setting CNB_LAYERS_DIR=/layers
Setting CNB_APP_DIR=/workspace
Setting CNB_PLATFORM_API=0.12
Setting CNB_DEPRECATION_MODE=quiet
Prepending /cnb/process and /cnb/lifecycle to PATH
Setting WORKDIR: '/workspace'
Setting default process type 'web'
Setting ENTRYPOINT: '/cnb/process/web'
Timer: Saving localhost:55019/some-org/kfwylzvwwb... started at 2024-01-30T15:51:05Z
Saving localhost:55019/some-org/kfwylzvwwb...
*** Images (1966546be8b9):
      localhost:55019/some-org/kfwylzvwwb

*** Image ID: 1966546be8b9dcb294a1076a457a57bf7bb3aa73904fd666f581213281336306
Timer: Saving localhost:55019/some-org/kfwylzvwwb... ran for 144.726225ms and ended at 2024-01-30T15:51:05Z
Timer: Exporter ran for 166.904572ms and ended at 2024-01-30T15:51:05Z
Timer: Cache started at 2024-01-30T15:51:05Z
Reading buildpack directory: /layers/simple_layers
Reading buildpack directory item: cached-launch-layer
Reading buildpack directory item: cached-launch-layer.toml
Reading buildpack directory item: launch-layer
Reading buildpack directory item: launch-layer.toml
Reading buildpack directory item: launch.toml
Reusing tarball for layer "simple/layers:cached-launch-layer" with SHA: sha256:86da3c03587957e4e7571259d7cefb913e991ddb19164862f40159362b78f3a0
Adding cache layer 'simple/layers:cached-launch-layer'
Layer 'simple/layers:cached-launch-layer' SHA: sha256:86da3c03587957e4e7571259d7cefb913e991ddb19164862f40159362b78f3a0
Timer: Cache ran for 375.724µs and ended at 2024-01-30T15:51:05Z
Successfully built image 'localhost:55019/some-org/kfwylzvwwb'

Documentation

Should this change be documented?
- Yes, see #___
- No

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5cbc93e) 79.66% compared to head (bfaafe9) 79.69%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2042      +/-   ##
==========================================
+ Coverage   79.66%   79.69%   +0.03%     
==========================================
  Files         176      176              
  Lines       13231    13249      +18     
==========================================
+ Hits        10539    10557      +18     
  Misses       2022     2022              
  Partials      670      670

Flag	Coverage Δ
os_linux	`78.62% <85.19%> (+0.06%)`	⬆️
os_macos	`76.30% <11.12%> (-0.11%)`	⬇️
os_windows	`79.08% <85.19%> (+0.06%)`	⬆️
unit	`79.69% <85.19%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Colin Casey <casey.colin@gmail.com>

pkg/project/project.go

edmorley · 2024-02-01T22:06:49Z

Thank you for implementing this! It's caught several people out (myself included), so looking forward to the better UX here :-)

Signed-off-by: Juan Bustamante <juan.bustamante@broadcom.com>

Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>

jjbustamante

Thanks a lot for this PR @colincasey, just a quick suggestion with the use of fmt

pkg/project/project.go

Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>

Signed-off-by: Colin Casey <casey.colin@gmail.com>

jjbustamante

Thank you @colincasey

Warn if project.toml contains keys not supported by schema

f662318

- also notifies when the schema version is missing and defaults to `0.1` Fixes buildpacks#1922 Signed-off-by: Colin Casey <casey.colin@gmail.com>

colincasey requested review from a team as code owners January 30, 2024 16:00

github-actions bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Jan 30, 2024

github-actions bot added this to the 0.33.0 milestone Jan 30, 2024

colincasey added 2 commits January 30, 2024 12:34

Limit acceptance to current version and up

77f7915

Signed-off-by: Colin Casey <casey.colin@gmail.com>

Increase test coverage

5b1219d

Signed-off-by: Colin Casey <casey.colin@gmail.com>

jjbustamante modified the milestones: 0.33.0, 0.34.0 Feb 1, 2024

edmorley reviewed Feb 1, 2024

View reviewed changes

pkg/project/project.go Outdated Show resolved Hide resolved

colincasey and others added 4 commits February 2, 2024 16:15

Merge branch 'main' into fix_1922_silently_ignoring_keys_in_project_toml

9841c43

Merge branch 'main' into fix_1922_silently_ignoring_keys_in_project_toml

96ab9c9

Merge branch 'main' into fix_1922_silently_ignoring_keys_in_project_toml

ec71d3c

Signed-off-by: Juan Bustamante <juan.bustamante@broadcom.com>

Update pack.go

214a376

Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>

jjbustamante requested changes Feb 7, 2024

View reviewed changes

pkg/project/project.go Show resolved Hide resolved

jjbustamante and others added 3 commits February 7, 2024 16:31

running make format

18b172f

Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>

Updating pack version for acceptance tests, it was moved to 0.34.0

d15c3e9

Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>

Use logger with ReadProjectDescriptor

da37994

Signed-off-by: Colin Casey <casey.colin@gmail.com>

github-actions bot removed the type/chore Issue that requests non-user facing changes. label Feb 10, 2024

colincasey requested a review from jjbustamante February 10, 2024 15:01

Merge branch 'main' into fix_1922_silently_ignoring_keys_in_project_toml

bfaafe9

jjbustamante approved these changes Feb 12, 2024

View reviewed changes

jjbustamante merged commit ded78f3 into buildpacks:main Feb 12, 2024
18 checks passed

colincasey deleted the fix_1922_silently_ignoring_keys_in_project_toml branch February 13, 2024 16:11

jjbustamante mentioned this pull request May 15, 2024

Warn misconfiguration keys in project.toml only for tables we own #2155

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warn if project.toml contains keys not supported by schema #2042

Warn if project.toml contains keys not supported by schema #2042

colincasey commented Jan 30, 2024 •

edited

Loading

codecov bot commented Jan 30, 2024 •

edited

Loading

edmorley commented Feb 1, 2024

jjbustamante left a comment

jjbustamante left a comment

Warn if project.toml contains keys not supported by schema #2042

Warn if project.toml contains keys not supported by schema #2042

Conversation

colincasey commented Jan 30, 2024 • edited Loading

Summary

Output

Before

After

Documentation

Related

codecov bot commented Jan 30, 2024 • edited Loading

Codecov Report

edmorley commented Feb 1, 2024

jjbustamante left a comment

Choose a reason for hiding this comment

jjbustamante left a comment

Choose a reason for hiding this comment

colincasey commented Jan 30, 2024 •

edited

Loading

codecov bot commented Jan 30, 2024 •

edited

Loading