-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate suggested builders from default trusted builders #2043
Separate suggested builders from default trusted builders #2043
Conversation
Signed-off-by: Colin Casey <casey.colin@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
==========================================
+ Coverage 79.63% 79.64% +0.01%
==========================================
Files 176 176
Lines 13214 13220 +6
==========================================
+ Hits 10522 10528 +6
Misses 2022 2022
Partials 670 670
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Colin Casey <casey.colin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Thanks @colincasey
…ed builders and trusted builders, there were several places that still had logic referencing suggested builders in the trusted context. This PR updates those code paths to only consider trusted builders and extracts out a shared function `IsKnownTrustedBuilder` that can be used for "is this a trusted builder" checks. Fixes buildpacks#2198 Signed-off-by: Colin Casey <casey.colin@gmail.com>
Summary
This PR replaces the
SuggestedBuilder
struct with aKnownBuilder
struct that contains the same details + the following boolean flags:Suggested
Trusted
These flags can be set on a
KnownBuilder
to control if it should be displayed as a suggested builder and/or be added as a default trusted builder.With these changes,
heroku/builder:20
has also been removed from the suggested list but remains as a default trusted builder.Output
pack builder suggest
Before
After
pack config trusted-builders list
(no difference since the default list is still all trusted)Before
After
Documentation
Related
Resolves #1500