Return an image even if inaccessible #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
When all run images are inaccessible, still return a run image. Pack will then provide a better error message to the end-user. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
AidanDelaney
force-pushed
the
fix/2087-getBestRunMirror
branch
from
4a6b9d4 to
0fdda16
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2088 +/- ##
==========================================
- Coverage 79.69% 79.69% -0.00%
==========================================
Files 176 176
Lines 13254 13257 +3
==========================================
+ Hits 10562 10564 +2
- Misses 2022 2023 +1
Partials 670 670
Flags with carried forward coverage won't be shown. Click here to find out more. |
natalieparellano
approved these changes
Mar 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all run images are inaccessible, still return a run image. Pack will then provide a better error message to the end-user.
Summary
When all run images are inaccessible, still return a run image. Pack will then provide a better error message to the end-user.
Output
Before
Produces the panic listed in #2087
After
Produces a build (in the
--pull-policy=nevercase), avoids the panic in all cases. Restores the previous behaviour.Documentation
Related
Resolves #2087