Pull run image using digest reference in analyzed.toml (not image name from extensions) #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e from extensions) Signed-off-by: Natalie Arellano <narellano@vmware.com>
github-actions
bot
added
the
type/enhancement
use the run image identifier to pull. Signed-off-by: Natalie Arellano <narellano@vmware.com>
(as run image reference may be a daemon image id) Signed-off-by: Natalie Arellano <narellano@vmware.com>
github-actions
bot
added
the
type/chore
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2127 +/- ##
==========================================
+ Coverage 70.51% 70.52% +0.02%
==========================================
Files 251 251
Lines 17950 17972 +22
==========================================
+ Hits 12655 12673 +18
- Misses 4478 4481 +3
- Partials 817 818 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
jjbustamante
reviewed
May 3, 2024
acceptance/acceptance_test.go
Outdated
| @@ -866,7 +866,8 @@ func testAcceptance( | |||
| h.SkipIf(t, !lifecycle.SupportsFeature(config.RunImageExtensions), "") | |||
| }) | |||
|
|
|||
| it("uses the 5 phases, and tries to pull the new run image before restore", func() { | |||
| // FIXME: now that we pull the run image AFTER the restore phases, the restorer fails to access the non-existent run image when it does restore checks | |||
There was a problem hiding this comment.
@natalieparellano What about this?
There was a problem hiding this comment.
I think the acceptance tests need some more extensive re-working to make this test possible again (we need to fill in the fixture with the registry repo name for the run image before starting the test). Maybe we could make an issue for it, and update the comment to reference it?
There was a problem hiding this comment.
I managed to fix the acceptance test, and in so doing uncovered that I was doing wrong things previously, so thank you.
…r restore When building to a daemon we need to pull the run image before restore in order to get target data Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
Oof tests are failing, will take a look |
The fixture changed, so the SHA changed Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
fix/run-image-pull
branch
from
7b59c0f to
3350bc9
Compare
jjbustamante
changed the title
jjbustamante
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pull run image using digest reference in analyzed.toml (not image name from extensions)
Output
Before
After
Documentation
Related
Resolves #___