When validating buildpack.toml, don't warn for keys that are actually defined #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined Signed-off-by: Natalie Arellano <narellano@vmware.com>
github-actions
bot
added
the
type/enhancement
| @@ -54,6 +54,6 @@ func (f *fetcher) Fetch(_ context.Context, imageName string, _ image.FetchOption | |||
| return nil, errors.New("not implemented") | |||
| } | |||
|
|
|||
| func (f *fetcher) CheckReadAccess(_ string, _ FetchOptions) bool { | |||
| func (f *fetcher) CheckReadAccess(_ string, _ image.FetchOptions) bool { | |||
There was a problem hiding this comment.
Not sure how this happened...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2161 +/- ##
==========================================
+ Coverage 70.53% 70.54% +0.01%
==========================================
Files 251 251
Lines 17980 17985 +5
==========================================
+ Hits 12680 12685 +5
Misses 4482 4482
Partials 818 818
Flags with carried forward coverage won't be shown. Click here to find out more. |
jjbustamante
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the overly aggressive validation that was added in #2123