Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip layer analysis when clearing cache #221

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Skip layer analysis when clearing cache #221

merged 1 commit into from
Jul 2, 2019

Conversation

jromero
Copy link
Member

@jromero jromero commented Jun 21, 2019 •
edited by ameyer-pivotal
Loading

Skip layer analysis for analyzer when clearing cache

  • For older lifecycles, continue to skip analyze altogether

Relates to buildpacks/lifecycle#138

Signed-off-by: Andrew Meyer ameyer@pivotal.io
Signed-off-by: Javier Romero jromero@pivotal.io

@jromero jromero force-pushed the feature/138-allow-multiple-tags branch from c114c93 to 27c62bd Compare June 21, 2019 21:34
@jromero jromero marked this pull request as ready for review June 21, 2019 21:43
@ekcasey
Copy link
Member

ekcasey commented Jun 21, 2019

@jromero I believe that if we are clearing the cache, we don't want to reuse layers from the analyzed image. Therefore it would be appropriate to skip analyze. I would assume that the absence of an analyzed.toml would simply result in the exporter never reusing layers (as it would on a first build).

@ameyer-pivotal ameyer-pivotal force-pushed the feature/138-allow-multiple-tags branch from 27c62bd to 90396d6 Compare June 27, 2019 21:48
@ameyer-pivotal ameyer-pivotal changed the title Always run analyze phase regardless of --clear-cache Skip layer analysis when clearing cache Jun 27, 2019
@ekcasey ekcasey force-pushed the feature/138-allow-multiple-tags branch from 90396d6 to 8641da5 Compare July 2, 2019 20:56
ekcasey
ekcasey approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@ekcasey ekcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending minor changes

acceptance/acceptance_test.go Outdated Show resolved Hide resolved
build/lifecycle.go Show resolved Hide resolved
build/lifecycle.go Outdated Show resolved Hide resolved
@jromero @ameyer-pivotal
Skip layer analysis for analyzer when clearing cache
b708148 
- For older lifecycles, continue to skip analyze altogether

Signed-off-by: Javier Romero <jromero@pivotal.io>
Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
@ekcasey ekcasey force-pushed the feature/138-allow-multiple-tags branch from 8641da5 to b708148 Compare July 2, 2019 21:20
@ekcasey
Copy link
Member

ekcasey commented Jul 2, 2019

@jromero and I are going to merge this w/o waiting for Travis b/c of degraded Travis availability.

@ekcasey ekcasey merged commit e734333 into master Jul 2, 2019
@jromero jromero deleted the feature/138-allow-multiple-tags branch July 5, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekcasey ekcasey ekcasey approved these changes

@hone hone Awaiting requested review from hone

@jkutner jkutner Awaiting requested review from jkutner

@sclevine sclevine Awaiting requested review from sclevine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jromero @ekcasey