Use the IMPLEMENTATION_GITHUB_TOKEN for the Registry #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was configured to use GITHUB_TOKEN for publishing to the Registry, which doesn't have enough permissions. This PR switches to using IMPLEMENTATION_GITHUB_TOKEN which should have sufficient permissions. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:bug
samj1912
previously approved these changes
Aug 26, 2022
samj1912
reviewed
Aug 26, 2022
| @@ -9,7 +9,7 @@ codeowners: | |||
| package: | |||
| repository: docker.io/buildpacksio/profile | |||
| register: true | |||
| registry_token: ${{ secrets.GITHUB_TOKEN }} | |||
| registry_token: ${{ secrets.IMPLEMENTATION_GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
@dmikusa-pivotal should it be using the implementation token to publish to dockerhub? Shouldn't it be some dockerhub credential?
There was a problem hiding this comment.
There are too many registries, lol. This is referring to the buildpacks registry. The docker creds are below, line 16 & 17.
This change in the descriptor file, results in the change on line 223 in the pb-create-package.yml file below.
I think/hope this will allow us to register the profile buildpack on https://registry.buildpacks.io. It didn't work when I tried to use the GITHUB_TOKEN.
samj1912
approved these changes
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was configured to use GITHUB_TOKEN for publishing to the Registry, which doesn't have enough permissions. This PR switches to using IMPLEMENTATION_GITHUB_TOKEN which should have sufficient permissions.
Signed-off-by: Daniel Mikusa dmikusa@vmware.com