-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lifecycle Configuration File #128
Closed
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
# Meta | ||
[meta]: #meta | ||
- Name: Add Lifecycle Configuration File | ||
- Start Date: 2020-12-17 | ||
- Author(s): @Jabrown85 | ||
- RFC Pull Request: (leave blank) | ||
- CNB Pull Request: (leave blank) | ||
- CNB Issue: (leave blank) | ||
- Supersedes: "N/A" | ||
|
||
# Summary | ||
[summary]: #summary | ||
|
||
In order to allow platforms to have more dynamic configurations, a new configuration file (`lifecycle.toml`) could be loaded by lifecycle binaries. | ||
|
||
# Definitions | ||
[definitions]: #definitions | ||
|
||
- Configuration File - New file to hold configuration that is currently achieved by ENV vars or flags. Proposed name `lifecycle.toml`. | ||
|
||
# Motivation | ||
[motivation]: #motivation | ||
|
||
- Why should we do this? | ||
- This will allow platform operators to change configuration in workflows previously not easily available to them. | ||
- What use cases does it support? | ||
- Platforms that run all phases in a single kubernetes pod will have the ability to write configuration before and after each phase for the upcoming phases using a volume. | ||
- What is the expected outcome? | ||
- Platforms that use the buildpacks.io published images `buildpacksio/lifecycle` will have a method to configure how lifecycle behaves by writing a file in a configurable location. | ||
- This will open up platform operators to be able to generate a configuration file based on information that may not be available at pod creation time. | ||
- Some platforms will move from setting `CNB_*` env vars to producing a `lifecycle.toml`. | ||
|
||
# What it is | ||
[what-it-is]: #what-it-is | ||
|
||
Target persona: platform operator, platform implementor | ||
|
||
A new `lifecycle.toml` will be read by lifecycle. By default, this path searched will be `/cnb/config/lifecycle.toml`. `CNB_CONFIG_PATH` would be available to override this location. | ||
|
||
An example `lifecycle.toml` might be produced by the platform with various inputs (source code, platform specific configuration, etc.): | ||
``` | ||
[config] | ||
app_dir = "/workspace/extracted-folder-name" | ||
cache_dir = "/volumes/cnb-cache" | ||
order_path = "/artifacts/generated-order.toml" | ||
no_color = true | ||
log_level = "debug" | ||
``` | ||
|
||
An example config resolution would be, in prioritized order, env `CNB_ORDER_PATH`, `[lifecycle.toml][config]order_path`, then the lifecycle default of `/cnb/order.toml`. | ||
|
||
The keys of the `[config]` table are expected to match the env var names, minus the `CNB_` prefix and lowercased. | ||
|
||
# How it Works | ||
[how-it-works]: #how-it-works | ||
|
||
Lifecycle will read in `CNB_CONFIG_PATH` or the default of `/cnb/config/lifecycle.toml` and prioritize the values found over lifecycle's defaults and before present env vars. | ||
|
||
If there is no configuration found, lifecycle will resolve configuration as it does today (env vars, defaults). | ||
|
||
# Drawbacks | ||
[drawbacks]: #drawbacks | ||
|
||
Why should we *not* do this? | ||
|
||
Another configuration file. | ||
|
||
# Alternatives | ||
[alternatives]: #alternatives | ||
|
||
- What other designs have been considered? | ||
- Lifecycle could load env vars from a known file location. e.g. `source lifecycle.env` or similar prior to resolving lifecycle configuration. | ||
- Lifecycle could only allow for non-path based inputs like `log_level` in `lifecycle.toml`, but add an additional path to to a known platform location. Example would be `/cnb/config/order.toml` for `CNB_ORDER_PATH`. This would allow platforms to use a volume at `/cnb/config` and write files that are fed into lifecycle in addition to a `lifecycle.toml` for non-path based configuration. | ||
- Why is this proposal the best? | ||
- A well defined configuration file feels less convoluted and less stack specific | ||
- What is the impact of not doing this? | ||
- Operators are forced to make assumptions about the stack a builder is built on to load up `CNB_` env vars from previous containers in a single k8s pod scenario. | ||
- Operators will be forced to configure distroless `buildpacksio/lifecycle` containers from env vars or not use distroless images | ||
|
||
# Prior Art | ||
[prior-art]: #prior-art | ||
|
||
TODO | ||
|
||
# Unresolved Questions | ||
[unresolved-questions]: #unresolved-questions | ||
|
||
- Is the convention based name of `CNB_ORDER_PATH` to `order_path` appropriate? We could introduce a schema for this file that is more rigid. | ||
- Do we need the root `[config]` table? | ||
|
||
|
||
# Spec. Changes (OPTIONAL) | ||
[spec-changes]: #spec-changes | ||
|
||
TODO |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should try to keep these keys matching the
lifecycle
flags exactly. So:app
instead ofapp_dir
order
instead oforder_path
OTOH, these more closely match the env vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and changed the names to be kebab-case, but I kept them matching the env variants for now. I was thinking it might make sense to be able to set some things that maybe aren't available as flags in the future. Like
CNB_REGISTRY_AUTH
isn't a flag, but you still might want to do the work to get that auth setup in the same pod. Similarly, there may be things like lifecycle feature flags or version selection that could be useful to have here that is likely to be available as an env var but may not have a flag name.