RFC: Rebase by Image Digest Reference #262
Conversation
|
Maintainers, As you review this RFC please queue up issues to be created using the following commands: Issues(none) |
Signed-off-by: Joey Brown <brown.joseph@salesforce.com>
Signed-off-by: Joey Brown <brown.joseph@salesforce.com>
joeybrown-sf
force-pushed
the
rebase/digest-ref
branch
from
861d51d to
b29020c
Compare
| 1. `lifecycle rebase my-repo/foo:v4` | ||
|
|
||
| Here are some examples of currently invalid rebase commands using **digest references**: | ||
| 1. `lifecycle rebase my-repo/foo@sha256:1234 myrepo/foo` |
There was a problem hiding this comment.
I wonder if introducing an explicit -previous-image flag would make things clearer:
lifecycle rebase -previous-image my-repo/foo@sha256:1234 myrepo/foo
If -previous-image is not provided we infer it from the first argument, just like analyzer.
There was a problem hiding this comment.
@natalieparellano Do you think I should reframe this RFC around this "previous-image" flag?
A new title might be Add optional "-previous-image" flag to lifecycle rebase.
There was a problem hiding this comment.
@joeybrown-sf up to you - personally I think the title you have still applies here and the flag is more of an implementation detail. Do we like this suggestion? It seems clearer to me, but maybe others feel differently. @jabrown85 do you have any thoughts?
There was a problem hiding this comment.
I think an explicit argument is fine here. I agree it is an implementation detail of the RFC as well.
|
@joeybrown-sf unless there are objections, can you update the examples with the |
|
@jabrown85 would you be interested in stewarding this one? |
natalieparellano
added
status/needs-steward
scope/team
|
Sure @natalieparellano! I got this one |
@hone Are you asking for one more RFC PR? Very similar to this one, except different labels? Or something else? |
Just updating the current RFC. |
Signed-off-by: Joey Brown <brown.joseph@salesforce.com>
joeybrown-sf
force-pushed
the
rebase/digest-ref
branch
from
4b944b7 to
6f4a4a1
Compare
Signed-off-by: Joey Brown <brown.joseph@salesforce.com>
Signed-off-by: Joey Brown <brown.joseph@salesforce.com>
joeybrown-sf
force-pushed
the
rebase/digest-ref
branch
from
2df092a to
0447b0b
Compare
jabrown85
added
Final Comment Period
status/voting
and removed
status/ready-for-review
labels
|
Voting scheduled to end January 12th |
|
Because this is a team RFC - we have unanimously agreed to forgo the final comment period. |
Handles buildpacks/rfcs#262 Signed-off-by: Jesse Brown <jabrown85@gmail.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Handles buildpacks/rfcs#262 Signed-off-by: Jesse Brown <jabrown85@gmail.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Readable