Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Private Registry Mirrors #285
base: main
Are you sure you want to change the base?
RFC: Private Registry Mirrors #285
Changes from 3 commits
103d73d
e21f678
54db935
83698ec
a98354e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking out loud here, I'm not sure if this is relevant or not...
There exists today a
pack config run-image-mirrors
that willThere is also a
pack config registry-mirrors
that willrun-image-mirrors
have been appliedIt's worth noting that while these translations update the
-run-image
provided to the lifecycle, they do NOT update stack.toml/run.toml i.e., these mirrors are "hidden" today in the sense that they are not persisted as metadata on the app image.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I remember - it would be helpful to describe how
CNB_REGISTRY_MIRRORS
env var for the lifecycle would be exposed in pack given the above stuff that exists today. I would really hope that we could avoid adding yet another toggle here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@buildpacks/platform-maintainers @jjbustamante do you have any thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to search in past issues and pull request to understand the reason for
pack config mirrors
commands. I found the following:The order of preference applied for for run image when
pack build
is executed:2.1 when
publish
, default to using the run-image mirror in the registry you are publishing the image to2.2 when
daemon
, defaults to using the run-image mirror in the same registry (colocated) as the builderpack config run-image-mirrors
Based on this, the new
CNB_REGISTRY_MIRRORS
seems to be like a new option to override point 4, right? something like:CNB_REGISTRY_MIRRORS
and pass it through the lifecycleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With luck I think the lifecycle could handle all of the mirror translations. We don't pull any images when running kaniko...