Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Procfile for Ruby sample app #47

Closed
wants to merge 1 commit into from

Conversation

almonk
Copy link

@almonk almonk commented Dec 16, 2019

Addresses #46.

Adds a standard Procfile to the ruby sample app to ensure it can be run correctly by the Heroku builder.

@jkutner
Copy link
Member

jkutner commented Dec 16, 2019

I think we can fix this in the Ruby buildpack (by generating a command with ${PORT:-5000} or similar). Alternatively, the /lifecycle/launcher can set a default PORT if there's isn't one provided.

Because of Procfile isn't part of the Cloud Native Buildpacks, I don't think we want to add it to the sample repo. If the project.toml spec gets a processes table, the ruby app.rb command could also be added there.

@jromero
Copy link
Member

jromero commented Feb 12, 2020

Hi @almonk,

Based on @jkutner's reply and our goal to keep sample apps as "pure" as possible I will be closing this as it seems like we have a different path forward. Thank you for your efforts. Much appreciated.

@jromero jromero closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants