Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making builpack image extensions feature non-experimental #378

Closed
sriram-mahavadi opened this issue Nov 3, 2023 · 14 comments · Fixed by #386 or #387
Closed

Making builpack image extensions feature non-experimental #378

sriram-mahavadi opened this issue Nov 3, 2023 · 14 comments · Fixed by #386 or #387
Milestone

Comments

@sriram-mahavadi
Copy link

Hi,

We are presently waiting for the buildpacks image extensions feature to be non-experimental so that we can use it in some prod use-cases. As discussed in the slack, this could be done in the next release. Please help clarify the ETA for this.

Thank you,
Sriram

@loewenstein
Copy link
Contributor

@pbusko @c0d1ngm0nk3y @modulo11 how sure are we that buildpacks/rfcs#301 will not require any breaking changes?

@loewenstein
Copy link
Contributor

@natalieparellano should we add #301 as a dependency, e.g. as a tasklist entry in the issue description? Are there any other issues or PRs pending that should be added as a dependency?

What do you think is a realistic timeline for platform api 0.13 and buildpack api 0.11?

@loewenstein
Copy link
Contributor

@natalieparellano do we need to include a change and bump to Buildpacks API as well and add this to the Buildpack API 0.11 milestone in addition?

@natalieparellano
Copy link
Member

do we need to include a change and bump to Buildpacks API as well and add this to the Buildpack API 0.11 milestone in addition?

We probably should. But, the platform is the only place where we enforce "experimental = true" in order to use extensions.

@natalieparellano
Copy link
Member

What do you think is a realistic timeline for platform api 0.13

I am consistently guilty of over-optimism, but it would be great to get this out before everyone disappears before the holidays. Let's discuss it in an upcoming working group.

@natalieparellano
Copy link
Member

Here's the current milestone for lifecycle 0.19.0: https://github.com/buildpacks/lifecycle/milestone/40 ...2 issues in flight, 2 not started but "small"

@natalieparellano
Copy link
Member

Current state of the world:

  • The spec has caveats everywhere that extensions are experimental (buildpack and platform)
  • In the lifecycle, you cannot build with extensions unless CNB_EXPERIMENTAL_MODE is warn or silent
    • The lifecycle will error if the provided order contains extensions
  • In pack, you cannot build with extensions unless pack config experimental is set
    • pack will error if the provided builder contains extensions
    • All other pack commands (pack builder create, pack extension <command>) are unguarded

@loewenstein
Copy link
Contributor

Sounds like that's two pull requests for the specs (or three, if the image extension spec has such notion as well).
One pull request for the lifecycle and one pull request for pack.

Is there an agreement to remove the "experimental" notices?

@loewenstein
Copy link
Contributor

Also, I suppose #383 and #384 have to be merged first.

@natalieparellano
Copy link
Member

Sounds like that's two pull requests for the specs (or three, if the image extension spec has such notion as well).

buildpack.md and image_extension.md are versioned together, so two pull requests (one buildpack, one platform) would be fine.

AFAIK there is no opposition to this change, #378 (comment) is simply to summarize what the change is.

@loewenstein
Copy link
Contributor

Adding the lifecycle change for the above mentioned spec changes to the issue: buildpacks/lifecycle#1276

@natalieparellano
Copy link
Member

@loewenstein are you planning to make the spec PR for this? We should be able to at least cut the spec in the coming week or so.

@loewenstein
Copy link
Contributor

#387 and #386

@natalieparellano
Copy link
Member

Closed as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants