Buildpack API Modes #100
Merged
Buildpack API Modes #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lifecycle must read buildpack API from buildpack.toml and either respect it or fail Signed-off-by: Emily Casey <ecasey@vmware.com>
jkutner
reviewed
Jun 25, 2020
jkutner
approved these changes
Jun 25, 2020
Signed-off-by: Emily Casey <ecasey@vmware.com> Co-authored-by: Joe Kutner <jpkutner@gmail.com>
ekcasey
force-pushed
the
buildpack-api-modes
branch
from
203e494 to
a468b18
Compare
nebhale
approved these changes
Jun 26, 2020
hone
reviewed
Jun 30, 2020
| - MUST either conform to the matching version of this specification when interfacing with the buildpack or | ||
| - return an error to the platform if it does not support `<buildpack API Version>` | ||
|
|
||
| The lifecycle MAY return an error to the platform if two or more buildpacks within a group declare buildpack API versions that the lifecycle cannot support together within a single build, even if both are supported independently. |
There was a problem hiding this comment.
Based on the RFC:
the spec may not change in a way that precludes buildpacks implementing different 0.x APIs from running together.
This seems contradictory, but I assume atm you mean 0.1 and 0.2+?
There was a problem hiding this comment.
I don't think it is contradictory. This error case would potentially apply to a future 0.4/1.0 incompatibility.
sclevine
approved these changes
Jul 7, 2020
sclevine
reviewed
Jul 7, 2020
sclevine
reviewed
Jul 7, 2020
Signed-off-by: Emily Casey <ecasey@vmware.com> Co-authored-by: Stephen Levine <stephen.levine@gmail.com>
ekcasey
force-pushed
the
buildpack-api-modes
branch
from
545ab43 to
2ca6cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifecycle must read buildpack API from buildpack.toml and either respect it or fail
Resolves #93
Related RFC: https://github.com/buildpacks/rfcs/blob/main/text/0041-api-version-compat.md