Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove buidpack API changes from platform/0.4 #122

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Remove buidpack API changes from platform/0.4 #122

merged 1 commit into from
Jul 29, 2020

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Jul 28, 2020

Remove buildpack API changes from platform/0.4 (windows buidpacks)

@ekcasey
remove buidpack API changes from platform/0.4
5c20235 
Signed-off-by: Emily Casey <ecasey@vmware.com>
@ekcasey ekcasey requested a review from a team as a code owner July 28, 2020 23:31
@nebhale nebhale requested review from a team and nebhale July 28, 2020 23:59
nebhale
nebhale reviewed Jul 29, 2020
View reviewed changes
Copy link
Contributor

@nebhale nebhale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing a discrepancy between this change and what I'd expect this change to be. Nope, I was wrong.

@nebhale nebhale merged commit 604e4a7 into platform/0.4 Jul 29, 2020
@nebhale nebhale deleted the remove-buildpack-api-changes branch July 29, 2020 01:33
@ekcasey ekcasey mentioned this pull request Jul 29, 2020
Merged
@ekcasey ekcasey added this to the Platform 0.4 milestone Jul 29, 2020
@ekcasey ekcasey linked an issue Jul 29, 2020 that may be closed by this pull request
Move windows related buildpack API changes to buildpack/0.4 #119
Closed
@ekcasey ekcasey mentioned this pull request Jul 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebhale nebhale nebhale approved these changes

Assignees
No one assigned
Labels
api/platform
Projects
None yet
Milestone
Platform 0.4
Development

Successfully merging this pull request may close these issues.

Move windows related buildpack API changes to buildpack/0.4
2 participants
@ekcasey @nebhale