Exporter: when no default process is specified, don't set a default process (even when there is only one process) #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocess (even when there is only one process) The lifecycle should be as transparent as possible and have no opinions. The current behavior could be surprising to some users. Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
This is technically a breaking change. I'm not sure if any/many folks would be impacted by it. |
|
repointed at |
ekcasey
approved these changes
Aug 19, 2020
|
cc @jromero |
jkutner
approved these changes
Aug 20, 2020
|
Related RFC: buildpacks/rfcs#110 |
hone
approved these changes
Aug 26, 2020
|
I am going to put this in draft for now because we would rather accept these changes in combination with those proposed in buildpacks/rfcs#110. |
jkutner
approved these changes
Sep 2, 2020
nebhale
approved these changes
Sep 9, 2020
ekcasey
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in service of buildpacks/lifecycle#378
The lifecycle should be as transparent as possible and have no opinions. The current behavior could be surprising to some users.
Goes hand-in-hand with #159
Signed-off-by: Natalie Arellano narellano@vmware.com