Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <layers>/order.toml to path resolution #182

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

jabrown85
Copy link
Contributor

Allowing <layers>/order.toml to resolve before a builder's /cnb/order.toml will let platforms control the buildpacks to be executed from inside the same pod. A platform may mount <layers> to a container that executes prior to /cnb/detector and can write an order.toml to be consumed by /cnb/detector without knowing anything about the builder to be used.

Allowing `<layers>/order.toml` to resolve before a builder's `/cnb/order.toml` will let platforms control the buildpacks to be executed from inside the same pod. A platform may mount `<layers>` to a container that executes prior to `/cnb/detector` and can write an `order.toml` to be consumed by `/cnb/detector` without knowing anything about the builder to be used.

Signed-off-by: Jesse Brown <jabrown85@gmail.com>
platform.md Outdated Show resolved Hide resolved
@hone
Copy link
Member

hone commented Jan 27, 2021

+1 on the idea of this change. My only other concern (also discussed in the linked RFC) is where this should live. Is it common for the platform to be writing things to the <layers>?

Signed-off-by: Jesse Brown <jabrown85@gmail.com>

Co-authored-by: Terence Lee <hone02@gmail.com>
@jabrown85
Copy link
Contributor Author

+1 on the idea of this change. My only other concern (also discussed in the linked RFC) is where this should live. Is it common for the platform to be writing things to the <layers>?

I put it at <layers> mostly for convenience and future proofing. I'm a bit concerned that /platform may be mounted read-only and that any future preparer stage that parses a project.toml would be unable to write an order.toml in that directory.

@nebhale nebhale requested a review from a team January 27, 2021 19:06
@hone
Copy link
Member

hone commented Feb 4, 2021

We talked about re-organizing where we store things. I don't think it should block this spec change, but we're definitely coming to a point where we need to deal with that sooner than later.

Signed-off-by: Jesse Brown <jabrown85@gmail.com>
@ekcasey ekcasey merged commit 667c60f into buildpacks:platform/0.6 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants