Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack removal: buildpack changes #336

Merged
merged 21 commits into from
Jul 13, 2023
Merged

Stack removal: buildpack changes #336

merged 21 commits into from
Jul 13, 2023

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Dec 6, 2022 •
edited
Loading

No description provided.

@natalieparellano
Update stacks to targets in buildpack.toml
84e00b6 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Update distributions
ae549c2 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Rename distributions -> distros for parity with platform
1231cb2 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Add target env variables
4165ecb 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Remove other references to stacks and mixins
eb6afa2 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Update TOC
ae5039b 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
natalieparellano commented Dec 6, 2022
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
@natalieparellano
Rename distros -> distributions
f865cb0 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
natalieparellano commented Dec 8, 2022
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
jabrown85
jabrown85 reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@jabrown85 jabrown85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

buildpack.md Show resolved Hide resolved
@natalieparellano natalieparellano mentioned this pull request Jan 9, 2023
Closed
@natalieparellano natalieparellano marked this pull request as ready for review January 26, 2023 15:44
@natalieparellano natalieparellano requested a review from a team as a code owner January 26, 2023 15:44
joe-kimmel-vmw
joe-kimmel-vmw reviewed Jan 26, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
joe-kimmel-vmw
joe-kimmel-vmw reviewed Feb 3, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
joe-kimmel-vmw
joe-kimmel-vmw reviewed Feb 8, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
@sambhav sambhav changed the base branch from main to buildpack/0.10 February 8, 2023 23:41
hone
hone reviewed Mar 2, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
hone
hone reviewed Mar 2, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Mar 3, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
natalieparellano and others added 6 commits March 3, 2023 14:19
@natalieparellano @hone
Update buildpack.md
1d39e56 
Co-authored-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano @hone
Update buildpack.md
c0cf852 
Co-authored-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Clarify matching criteria
c985eeb 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Distribution can have only one version
8652ec5 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Merge branch 'buildpack/0.10' into stack-removal/buildpack
b127b3d
@natalieparellano
Update buildpack.md
7bec231 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

@hone @samj1912 this is ready for another look

sambhav
sambhav reviewed Mar 3, 2023
View reviewed changes
buildpack.md Show resolved Hide resolved
@natalieparellano
Copy link
Member Author

I made the following table to summarize the difference in behavior between new and old platforms and buildpacks, with mitigation strategies for backwards compatibility:

Screenshot 2023-03-03 at 3 38 16 PM

@natalieparellano natalieparellano mentioned this pull request Mar 6, 2023
Merged
@natalieparellano
Copy link
Member Author

Backwards compat strategy summarized here: https://docs.google.com/spreadsheets/d/1_lUDh8V_A6SHV9w2ioGwqAu821WWaItSYiUKqrlmr_w/edit#gid=240821534

@natalieparellano
Update buildpack.md
77ab37b 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
natalieparellano commented Mar 21, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Mar 21, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
@natalieparellano
Apply suggestions from code review
00cecc2 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Extensions specify targets
058949f 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
joe-kimmel-vmw
joe-kimmel-vmw reviewed Jun 6, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
buildpack.md Show resolved Hide resolved
buildpack.md Outdated Show resolved Hide resolved
buildpack.md Show resolved Hide resolved
natalieparellano
natalieparellano commented Jun 6, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
@natalieparellano
Apply suggestions from code review
9587e8c 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Clarify target matching
5b7eade 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
natalieparellano commented Jun 7, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
@natalieparellano
Apply suggestions from code review
a05c441 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
sambhav
sambhav reviewed Jul 10, 2023
View reviewed changes
buildpack.md Outdated
6) the stack provides the mixin `<mixin>` and the buildpack requires both `run:<mixin>` and `build:<mixin>`
7) the stack provides the mixins `build:<mixin>` and `run:<mixin>` the buildpack requires `<mixin>`
The lifecycle MUST run `/bin/detect` for all extensions and buildpacks in a group in a container using a common build environment.
If any buildpack in a group fails to declare a target in `buildpack.toml` matching the build-time and runtime base images, the lifecycle MUST fail detection for the group. For matching criteria, see [buildpack.toml](#buildpacktoml-toml).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we say that the the buildpack MUST declare the target but later in line 1106 it is a SHOULD.

Is this a required field or a recommended field?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added clarification in 7fd95e8

sambhav
sambhav reviewed Jul 10, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
buildpack.md Outdated Show resolved Hide resolved
buildpack.md

If an `order` is specified, then `stacks` MUST NOT be specified.

Tools reading `buildpack.toml` will translate any section that sets `stacks.id = "io.buildpacks.stacks.bionic"` to:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we end up updating the lifecycle to traslate stack ids to targets based on the information present in the OCI labels/annotations and the files present in the images?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - that is described in the platform spec PR here: https://github.com/buildpacks/spec/pull/335/files#diff-e603760990971da3f77be4bb8d77c3405098f006814fd8c054d2d15f395b8330R1118-R1122

@natalieparellano @sambhav
Apply suggestions from code review
db802b2 
Co-authored-by: Sambhav Kothari <skothari44@bloomberg.net>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
natalieparellano commented Jul 12, 2023
View reviewed changes
buildpack.md Outdated Show resolved Hide resolved
@natalieparellano
Update buildpack.md
7fd95e8 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

@samj1912 - I think I addressed your feedback. Can you take another look?

@natalieparellano natalieparellano merged commit e16c633 into buildpack/0.10 Jul 13, 2023
@natalieparellano natalieparellano deleted the stack-removal/buildpack branch July 13, 2023 15:28
This was referenced Feb 5, 2024
Closed
Closed
@Malax Malax mentioned this pull request Feb 8, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-kimmel-vmw joe-kimmel-vmw joe-kimmel-vmw left review comments

@jabrown85 jabrown85 jabrown85 left review comments

@sambhav sambhav sambhav approved these changes

@hone hone Awaiting requested review from hone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@natalieparellano @hone @jabrown85 @sambhav @joe-kimmel-vmw