add lifecycle output to update stack after rebase #360
Conversation
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
fixes link to image extension md file
platform.md
Outdated
| @@ -840,6 +840,8 @@ Usage: | |||
| - `run-image.reference` SHALL uniquely identify `<run-image>` | |||
| - `run-image.top-layer` SHALL be set to the uncompressed digest of the top layer in `<run-image>` | |||
| - The value of `io.buildpacks.stack.*` labels SHALL be modified to that of the new `run-image` | |||
| - `stack.run-image.image` SHALL uniquely identify `<run-image>` | |||
| - `stack.run-image.mirrors` SHALL be updated to include the new image mirrors | |||
There was a problem hiding this comment.
How will the run image mirrors be identified?
There was a problem hiding this comment.
(During build they come from stack.toml - soon to be run.toml in future platform APIs - but we don't have this file during rebase.)
There was a problem hiding this comment.
Changes has been made @natalieparellano
Signed-off-by: Hernan Garcia <hernan.garcia@percona.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Hernan Garcia <hernandanielg@gmail.com>
platform.md
Outdated
| @@ -840,6 +840,9 @@ Usage: | |||
| - `run-image.reference` SHALL uniquely identify `<run-image>` | |||
| - `run-image.top-layer` SHALL be set to the uncompressed digest of the top layer in `<run-image>` | |||
| - The value of `io.buildpacks.stack.*` labels SHALL be modified to that of the new `run-image` | |||
| - **If** the provided `<run-image>` is not found in `stack.run-image.image` or `stack.run-image.mirrors`: | |||
There was a problem hiding this comment.
Sorry this might be a dumb question, but does this mean every new run image released needs to have some sort of mapping/record/reference indicated in the stack?
There was a problem hiding this comment.
I think it depends - if you want stack.run-image.mirrors to have data, then yes the mapping must exist. Worth noting: future versions of the spec do away with stack.toml in favor of run.toml, which now contains a list of run images (and associated mirrors for each). More information could be found here: https://github.com/buildpacks/spec/pull/335/files#diff-e603760990971da3f77be4bb8d77c3405098f006814fd8c054d2d15f395b8330R934-R939 and here: https://github.com/buildpacks/spec/pull/335/files#diff-e603760990971da3f77be4bb8d77c3405098f006814fd8c054d2d15f395b8330R1238
@hernandanielg I'm realizing that this PR should probably be pointed at #335 due to the aforementioned changes. Are you able to rebase? There will likely be a merge conflict.
hernandanielg
changed the base branch from
platform/0.12
to
stack-removal/platform
Signed-off-by: Hernan Garcia <hernandanielg@gmail.com>
|
Hey @natalieparellano changes has been done - can you please review them? 🙏🏻 |
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Hernan Garcia <hernandanielg@gmail.com>
if the provided run image does not match existing metadata. See buildpacks/spec#360 Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
…1104) * When rebasing, update stack/runImage key in lifecycle metadata label if the provided run image does not match existing metadata. See buildpacks/spec#360 Signed-off-by: Natalie Arellano <narellano@vmware.com> * Update rebaser_test.go Signed-off-by: Natalie Arellano <narellano@vmware.com> --------- Signed-off-by: Natalie Arellano <narellano@vmware.com>
This is related to buildpacks/lifecycle#1098
As for now the Spec is missing to specify the need to update the Stack metadata so it will reflect new information after image rebase process