Added a project.toml extension #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
nebhale
suggested changes
Jan 30, 2020
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
elbandito
reviewed
Apr 12, 2020
| value = "-Xmx1g" | ||
| ``` | ||
|
|
||
| ## `[metadata]` |
There was a problem hiding this comment.
Hi @jkutner we should remove references to metadata support. While the project.toml file supports metadata, we're currently not doing anything with it. I imagine we'll mostly integrate this functionality with Lifecycle via project-metadata.toml.
There was a problem hiding this comment.
I think this is meant to be different from project-metadata.toml. This is basically a section for arbitrary metadata about the project/repo, which might not even have anything to do with buildpacks/lifecycle
jromero
reviewed
Apr 13, 2020
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
sclevine
approved these changes
Apr 17, 2020
sclevine
approved these changes
Apr 17, 2020
ekcasey
reviewed
Apr 17, 2020
|
Apologies, the new GitHub app removed all of the reviewers when I tried to add @ekcasey |
jromero
approved these changes
Apr 17, 2020
hone
approved these changes
Apr 18, 2020
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
ekcasey
approved these changes
Apr 20, 2020
nebhale
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from RFC 32.