Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage for file_regex status check #1447

Closed
2 tasks done
prathmesh4321 opened this issue Apr 20, 2023 · 3 comments · Fixed by #1511
Closed
2 tasks done

Add coverage for file_regex status check #1447

prathmesh4321 opened this issue Apr 20, 2023 · 3 comments · Fixed by #1511
Assignees
@braeeast2001
Labels
good first issue good first issue for new contributor regression-test issues related to regression test or missing code coverage
Milestone
buildtest version...

Comments

@prathmesh4321
Copy link
Collaborator

Please describe your feature

Add coverage for status check of file_regex. See https://app.codecov.io/gh/buildtesters/buildtest/blob/devel/buildtest/buildsystem/checks.py

Screen Shot 2023-04-19 at 10 51 18 PM

Suggest potential solution

No response

Additional Information

No response

Post question in Slack

  • I agree that I posted my question in slack before creating this issue

Is there an existing issue

  • I confirm there is no existing issue for this issue
@prathmesh4321 prathmesh4321 added the regression-test issues related to regression test or missing code coverage label Apr 20, 2023
@prathmesh4321 prathmesh4321 changed the title [FEATURE]: Add coverage for file_regex status check Add coverage for file_regex status check Apr 20, 2023
@shahzebsiddiqui shahzebsiddiqui added the good first issue good first issue for new contributor label Apr 26, 2023
@shahzebsiddiqui
Copy link
Member

@braeeast2001 i will be assigning this task to you

@shahzebsiddiqui shahzebsiddiqui added this to the buildtest version 1.5 milestone May 30, 2023
@shahzebsiddiqui
Copy link
Member

can you please take a look at https://github.com/buildtesters/buildtest/blob/devel/tests/builders/test_builders.py file it has the tests for all the status checks

@shahzebsiddiqui
Copy link
Member

this is the test for file_regex that we should use for the regression test. Simply create a symbolic link https://github.com/buildtesters/buildtest/blob/devel/tutorials/test_status/regex_on_filename.yml. The symlink are created for other files in the root of the directory https://github.com/buildtesters/buildtest/tree/devel/tests/builders for buildspecs that point to ones in the tutorials directory.

@braeeast2001 braeeast2001 linked a pull request Jul 7, 2023 that will close this issue
Add coverage to file_regex status check method #1511
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@braeeast2001 braeeast2001

Labels
good first issue good first issue for new contributor regression-test issues related to regression test or missing code coverage
Projects
None yet
Milestone
buildtest version 1.5
Development

Successfully merging a pull request may close this issue.

Add coverage to file_regex status check method braeeast2001/buildtest
3 participants
@shahzebsiddiqui @prathmesh4321 @braeeast2001