Add coverage to file_regex status check method #1511

braeeast2001 · 2023-07-03T18:09:28Z

Add test_file_regex to test_builders.py using regex_on_filename.yml.

szuananwar

line 146: These is no file_regex.yml file in tutorials/test_status to link to, please make sure the name of yml file is correct.

tests/builders/test_builders.py

Corrected file name

tests/builders/test_builders.py

Corrected file name

codecov · 2023-07-05T21:05:39Z

Codecov Report

Patch coverage has no change and project coverage change: +0.44 🎉

Comparison is base (bf48aa1) 77.54% compared to head (b6c62b2) 77.97%.

❗ Current head b6c62b2 differs from pull request most recent head e111ca3. Consider uploading reports for the commit e111ca3 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #1511      +/-   ##
==========================================
+ Coverage   77.54%   77.97%   +0.44%     
==========================================
  Files          57       57              
  Lines        6615     6615              
==========================================
+ Hits         5129     5158      +29     
+ Misses       1486     1457      -29

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

tests/builders/test_builders.py

szuananwar

Please change the comment in 143 to match with the correct yml file name that will be linked for test.

Fixed comment in line 143

szuananwar

The comment in the methods matches the linked yml file.

tests/builders/test_builders.py

szuananwar · 2023-07-07T13:25:05Z

@braeeast2001 for style check, please run buildtest sytle -a
see this for more info: https://buildtest.readthedocs.io/en/devel/contributing/code_contribution_guide.html

…ing tested

szuananwar · 2023-07-09T05:05:39Z

@shahzebsiddiqui I think @braeeast2001 first should check if the file is exists in the directory then do a regex check. I think she should use this test https://github.com/buildtesters/buildtest/blob/devel/tutorials/test_status/exists.yml for her regression test. What do you think?

…dtest into Brae'zah_Patch

tests/builders/test_builders.py

tutorials/test_status/regex_on_invailds.yml

shahzebsiddiqui · 2023-07-11T13:14:55Z

tests/builders/test_builders.py

@@ -151,9 +151,20 @@ def test_multicompilers_with_script_schema():


 def test_regex_check():
- """This test buildspec using status check with 'status_regex'"""
+ """This test buildspec using status check with 'status_regex'"""


change status_regex -> regex in doc string

Create new test for valid file_name with invalid regex and correct spelling mistake

…dtest into Brae'zah_Patch

tutorials/test_status/regex_on_invalids.yml

szuananwar

Thanks @braeeast2001 for making all the necessary changes.
The style check is failed, please run buildtest sytle -a
and see this for more info: https://buildtest.readthedocs.io/en/devel/contributing/code_contribution_guide.html

and buildspec was invalid

szuananwar · 2023-07-11T19:37:39Z

tests/builders/test_builders.py

- os.path.join(here, "regex_on_invalids.yml")],
+ buildspecs=[
+ os.path.join(here, "regex_on_filename.yml"),
+ os.path.join(here, "regex_on_invalids.yml"),


Please delete the comma , before ]

Update test_builders.py to add file_regex status check

402985d

pull-request-size bot added the size/S label Jul 3, 2023

braeeast2001 closed this Jul 3, 2023

braeeast2001 reopened this Jul 3, 2023

shahzebsiddiqui requested review from kingxleyy and szuananwar July 3, 2023 18:36

shahzebsiddiqui assigned braeeast2001 Jul 3, 2023

szuananwar reviewed Jul 3, 2023

View reviewed changes

tests/builders/test_builders.py Outdated Show resolved Hide resolved

Update test_builders.py

f6ab377

Corrected file name

szuananwar reviewed Jul 3, 2023

View reviewed changes

tests/builders/test_builders.py Outdated Show resolved Hide resolved

braeeast2001 changed the title ~~Update test_builders.py to add file_regex status check~~ Add coverage to file_regex status check method Jul 5, 2023

Update test_builders.py

12550ba

Corrected file name

szuananwar reviewed Jul 5, 2023

View reviewed changes

tests/builders/test_builders.py Outdated Show resolved Hide resolved

szuananwar reviewed Jul 5, 2023

View reviewed changes

Update test_builders.py

7b2d489

Fixed comment in line 143

szuananwar reviewed Jul 6, 2023

View reviewed changes

shahzebsiddiqui reviewed Jul 7, 2023

View reviewed changes

tests/builders/test_builders.py Outdated Show resolved Hide resolved

shahzebsiddiqui marked this pull request as ready for review July 7, 2023 13:25

shahzebsiddiqui added 2 commits July 7, 2023 09:55

update docstring for the test to be more meaningful to the what is be…

2a4c863

…ing tested

Merge branch 'devel' into Brae'zah_Patch

e7b1a68

braeeast2001 linked an issue Jul 7, 2023 that may be closed by this pull request

Add coverage for file_regex status check #1447

Closed

2 tasks

braeeast2001 closed this Jul 9, 2023

braeeast2001 deleted the Brae'zah_Patch branch July 9, 2023 15:51

braeeast2001 restored the Brae'zah_Patch branch July 9, 2023 16:37

braeeast2001 reopened this Jul 9, 2023

braeeast2001 added 2 commits July 10, 2023 08:47

Create symlink and update line 143

a931216

Merge branch 'Brae'zah_Patch' of https://github.com/braeeast2001/buil…

f48be7a

…dtest into Brae'zah_Patch

pull-request-size bot added the size/XS label Jul 10, 2023

braeeast2001 and others added 4 commits July 10, 2023 10:23

Delete regex_on_filename.yml

ff7cfc5

Update test_builders.py

41fb1d3

Merge branch 'Brae'zah_Patch' of https://github.com/braeeast2001/buil…

97d0598

…dtest into Brae'zah_Patch

Update test_builders.py

2846d99

szuananwar reviewed Jul 10, 2023

View reviewed changes

tests/builders/test_builders.py Show resolved Hide resolved

Re-add Dr. Anwar method

16038d0

pull-request-size bot added size/S and removed size/XS labels Jul 10, 2023

braeeast2001 and others added 4 commits July 10, 2023 12:22

Correct Dr. A test name

1a15992

Create NEW file and Update test_builders.py

32102dd

Add New lien at the END of the file

bf83c74

Merge branch 'devel' into Brae'zah_Patch

ccc40d6

shahzebsiddiqui reviewed Jul 11, 2023

View reviewed changes

tutorials/test_status/regex_on_invailds.yml Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed Jul 11, 2023

View reviewed changes

braeeast2001 added 2 commits July 11, 2023 10:03

Update regex_on_invalids.yml

d5ad3ea

Create new test for valid file_name with invalid regex and correct spelling mistake

Merge branch 'Brae'zah_Patch' of https://github.com/braeeast2001/buil…

0468a1a

…dtest into Brae'zah_Patch

pull-request-size bot added size/M and removed size/S labels Jul 11, 2023

shahzebsiddiqui reviewed Jul 11, 2023

View reviewed changes

tutorials/test_status/regex_on_invalids.yml Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed Jul 11, 2023

View reviewed changes

tutorials/test_status/regex_on_invalids.yml Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed Jul 11, 2023

View reviewed changes

tutorials/test_status/regex_on_invalids.yml Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed Jul 11, 2023

View reviewed changes

tutorials/test_status/regex_on_invalids.yml Outdated Show resolved Hide resolved

Correct spelling mistakes

1f2cc16

szuananwar reviewed Jul 11, 2023

View reviewed changes

shahzebsiddiqui added 2 commits July 11, 2023 15:31

fix issue with test it must be in the tests/builders directory

6ad6c25

and buildspec was invalid

fix style check issue

b6c62b2

szuananwar reviewed Jul 11, 2023

View reviewed changes

fix issue with yamllint

e111ca3

shahzebsiddiqui merged commit 78e23cf into buildtesters:devel Jul 11, 2023
27 of 29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add coverage to file_regex status check method #1511

Add coverage to file_regex status check method #1511

braeeast2001 commented Jul 3, 2023 •

edited

Loading

szuananwar left a comment

codecov bot commented Jul 5, 2023 •

edited

Loading

szuananwar left a comment

szuananwar left a comment

szuananwar commented Jul 7, 2023

szuananwar commented Jul 9, 2023

shahzebsiddiqui Jul 11, 2023

szuananwar left a comment

szuananwar Jul 11, 2023

Add coverage to file_regex status check method #1511

Add coverage to file_regex status check method #1511

Conversation

braeeast2001 commented Jul 3, 2023 • edited Loading

szuananwar left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 5, 2023 • edited Loading

Codecov Report

szuananwar left a comment

Choose a reason for hiding this comment

szuananwar left a comment

Choose a reason for hiding this comment

szuananwar commented Jul 7, 2023

szuananwar commented Jul 9, 2023

shahzebsiddiqui Jul 11, 2023

Choose a reason for hiding this comment

szuananwar left a comment

Choose a reason for hiding this comment

szuananwar Jul 11, 2023

Choose a reason for hiding this comment

braeeast2001 commented Jul 3, 2023 •

edited

Loading

codecov bot commented Jul 5, 2023 •

edited

Loading